Skip to content

Conversation

@etnlbck
Copy link
Contributor

@etnlbck etnlbck commented Oct 21, 2023

Problem solved

Addressing #1543
Adding support for i18n.

Changes made

Added i18n config and provider to react-core.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

🦋 Changeset detected

Latest commit: d36d3b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@thirdweb-dev/react-core Minor
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Minor
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@etnlbck etnlbck changed the title feat: i18n | React-Core Feature: i18n | React-Core Oct 21, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
i18next 23.6.0 None +0 595 kB adrai
react-i18next 13.3.1 None +3 980 kB adrai

@iketw
Copy link
Contributor

iketw commented Oct 23, 2023

@etnlbck thanks for opening this PR! We are actively working on this and will have i18n support out this week :). Our solution does not include i18next as we try to be library agnostic but you will be able to pass your translated strings into our SDKs. Thanks again! I'll go ahead and close this PR for now.

@iketw iketw closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants