Skip to content

Conversation

@cppfuns
Copy link

@cppfuns cppfuns commented Oct 26, 2023

Official brand upgrade, changed from opside to lumoz

@cppfuns cppfuns requested a review from jnsdls as a code owner October 26, 2023 08:28
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: bc4d9b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls
Copy link
Member

jnsdls commented Oct 26, 2023

hi there @cppfuns.

This change sadly won't work here as this is generated code that you're manually updating and as such will get overwritten.

To make the change you're trying to make please do one of these 2 things:

  1. Make the changes in a PR to: https://github.com/ethereum-lists/chains -> this will automatically then get updated in a subsequent build on our side.
  2. Alternatively go here: https://thirdweb.com/solutions/chains and fill out the form -> we will then take the information you provide there and make the update in our system.

Thanks!

I'll be closing this as this code change won't actually work, please feel free to raise an issue if you have questions!

@jnsdls jnsdls closed this Oct 26, 2023
jnsdls added a commit that referenced this pull request Jun 19, 2024
* chore(routing): massively simplify page routing and middleware

* refactor: Remove unused code and files

---------

Signed-off-by: Jonas Daniels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants