Skip to content

[SmartWallet] expose data in smart wallet utils #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquim-verges merged 1 commit into from
Oct 28, 2023
Merged

[SmartWallet] expose data in smart wallet utils #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/new-poems-exercise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/wallets": patch
---

Expose data param for smart wallet util functions
7 changes: 5 additions & 2 deletions packages/wallets/src/evm/connectors/smart-wallet/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
isContractDeployed,
ThirdwebSDK,
} from "@thirdweb-dev/sdk";
import { BytesLike } from "ethers";

export type AccessibleSmartWallets = {
owned: string;
Expand Down Expand Up @@ -81,12 +82,13 @@ export async function isSmartWalletDeployed(
chain: ChainOrRpcUrl,
factoryAddress: string,
personalWalletAddress: string,
data: BytesLike = "0x",
) {
const readOnlySDK = getSDK(chain);
const factoryContract = await readOnlySDK.getContract(factoryAddress);
const accountAddress = await factoryContract.call("getAddress", [
personalWalletAddress,
"0x",
data,
]);
const isDeployed = await isContractDeployed(
accountAddress,
Expand All @@ -106,12 +108,13 @@ export async function getSmartWalletAddress(
chain: ChainOrRpcUrl,
factoryAddress: string,
personalWalletAddress: string,
data: BytesLike = "0x",
): Promise<string> {
const readOnlySDK = getSDK(chain);
const factoryContract = await readOnlySDK.getContract(factoryAddress);
const accountAddress = await factoryContract.call("getAddress", [
personalWalletAddress,
"0x",
data,
]);
return accountAddress;
}