Isaac/react sdk migration #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 67.49% 67.47% -0.02%
==========================================
Files 292 292
Lines 11010 11017 +7
Branches 1510 1512 +2
==========================================
+ Hits 7431 7434 +3
- Misses 2957 2961 +4
Partials 622 622 ☔ View full report in Codecov by Sentry. |
jnsdls
reviewed
Dec 15, 2023
Member
jnsdls
left a comment
jnsdls
left a comment
There was a problem hiding this comment.
initial review, I'm sure there's more but there's so much to read through here
jnsdls
reviewed
Jan 2, 2024
Member
jnsdls
left a comment
jnsdls
left a comment
There was a problem hiding this comment.
also add separate minor changeset for react with the changelog of the new features
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Merging @paperxyz/react-client-sdk into @thirdweb-dev/react
Changes made
How to test
transactionId: be48be00-868d-4973-abe3-9851f3e8d136
iframe: data-thirdweb-sdk-version="@thirdweb-dev/[email protected]”
transaction hash