Skip to content

update to Contracts SDK 3.1.5 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnsdls merged 4 commits into from
Sep 1, 2022
Merged

update to Contracts SDK 3.1.5 #36

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a55958
update to Contracts SDK 3.1.5
joaquim-verges Aug 31, 2022
faf01d0
fix test setup
joaquim-verges Aug 31, 2022
6c81e87
fix test deploys
joaquim-verges Aug 31, 2022
fe1de68
Merge branch 'main' into joaquim/update_contracts
jnsdls Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test setup
  • Loading branch information
@joaquim-verges
joaquim-verges committed Aug 31, 2022
commit faf01d023f6c7cd9f64a3d5d640668e6d26ed11a
17 changes: 4 additions & 13 deletions packages/sdk/test/before-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,13 @@ before(async () => {
const thirdwebRegistryAddress = await thirdwebFactoryDeployer.registry();
registryAddress = thirdwebFactoryDeployer.address;

await thirdwebFactoryDeployer.deployed();

await registryContract.grantRole(
await registryContract.OPERATOR_ROLE(),
thirdwebFactoryDeployer.address,
);

const thirdwebFeeDeployer = await new ethers.ContractFactory(
TWFee__factory.abi,
TWFee__factory.bytecode,
)
.connect(signer)
.deploy(trustedForwarderAddress, thirdwebFactoryDeployer.address);
await thirdwebFactoryDeployer.deployed();

// Mock publisher for tests
const mockPublisher = (await new ethers.ContractFactory(
MockContractPublisher__factory.abi,
Expand Down Expand Up @@ -151,12 +145,9 @@ before(async () => {
const nativeTokenWrapperAddress = getNativeTokenByChainId(
ChainId.Hardhat,
).wrapped.address;
return await contractFactory.deploy(
nativeTokenWrapperAddress,
thirdwebFeeDeployer.address,
);
return await contractFactory.deploy(nativeTokenWrapperAddress);
default:
return await contractFactory.deploy(thirdwebFeeDeployer.address);
return await contractFactory.deploy();
}
}

Expand Down