Skip to content

Add callbacks to next and express auth #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-maj merged 12 commits into from
Sep 1, 2022
Merged

Add callbacks to next and express auth #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cfadada
Add callbacks to next and express auth
adam-maj Aug 31, 2022
3bb9796
Merge branch 'main' into am/auth
adam-maj Aug 31, 2022
29f2d18
Merge branch 'main' into am/auth
adam-maj Aug 31, 2022
c43bd1a
Add changeset
adam-maj Aug 31, 2022
52caf18
Merge branch 'am/auth' of https://github.com/thirdweb-dev/js into am/…
adam-maj Aug 31, 2022
cb1674b
Merge branch 'main' into am/auth
adam-maj Aug 31, 2022
7441383
Omit address from user type
adam-maj Aug 31, 2022
b388e06
Update callback types
adam-maj Aug 31, 2022
801b7a6
Merge branch 'main' into am/auth
adam-maj Sep 1, 2022
d683c9c
Update callback function types
adam-maj Sep 1, 2022
f66f147
Merge branch 'am/auth' of https://github.com/thirdweb-dev/js into am/…
adam-maj Sep 1, 2022
b13e7ed
Merge branch 'main' into am/auth
jnsdls Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Omit address from user type
  • Loading branch information
@adam-maj
adam-maj committed Aug 31, 2022
commit 7441383e7c6126cb360c1eb669fc28d9e461923a
4 changes: 2 additions & 2 deletions packages/auth/src/express/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export type ThirdwebAuthConfig = {
authUrl?: string;
callbacks?: {
login?: (address: string) => void;
user?: (address: string) => ThirdwebAuthUser;
user?: (address: string) => Omit<ThirdwebAuthUser, "address">;
};
};

Expand All @@ -18,7 +18,7 @@ export type ThirdwebAuthContext = {
domain: string;
callbacks?: {
login?: (address: string) => void;
user?: (address: string) => ThirdwebAuthUser;
user?: (address: string) => Omit<ThirdwebAuthUser, "address">;
};
};

Expand Down
4 changes: 2 additions & 2 deletions packages/auth/src/next/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type ThirdwebAuthConfig = {
domain: string;
callbacks?: {
login?: (address: string) => void;
user?: (address: string) => ThirdwebAuthUser;
user?: (address: string) => Omit<ThirdwebAuthUser, "address">;
};
};

Expand All @@ -16,7 +16,7 @@ export type ThirdwebAuthContext = {
domain: string;
callbacks?: {
login?: (address: string) => void;
user?: (address: string) => ThirdwebAuthUser;
user?: (address: string) => Omit<ThirdwebAuthUser, "address">;
};
};

Expand Down