[Auth] complete auth update & restructure #460
Conversation
🦋 Changeset detectedLatest commit: 729e813 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
@adam-maj i would also rename
AbstractSigner -> AbstractWallet
GenericSignerWallet -> GenericAuthWallet (open to other names)
but need to make it clear cut when we use Signers (privatekey holders) vs Wallets (signer holders) - the hierarchy needs to be clear
|
/release-pr |
|
@adam-maj RE the conflicts, almost all of these files now live in |
|
/release-pr |
|
/release-pr |
| asyncHandler((req: Request, res: Response) => | ||
| loginHandler(req, res, ctx as ThirdwebAuthContext), | ||
| ), |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
/release-pr |
|
@joaquim-verges PR should be ready to go and tested everything on express/react. Here are the versions: Docs: https://docs-bypmstttd.thirdweb-preview.com/auth/server-frameworks/express Things to test:
|
|
tested Next w/ EVM and Solana wallets - looking good from my side |
.changeset/cuddly-meals-wash.md
Outdated
| "@thirdweb-dev/wallets": minor | ||
| --- | ||
|
|
||
| Breaking change and upgrade to auth and minor update to related packages |
There was a problem hiding this comment.
@adam-maj we need some clean release notes here for auth - and noting separately any breaking change for each package.
remember that this shows up in the GH release notes
| @@ -0,0 +1,613 @@ | |||
| import type { Chain } from "@wagmi/core"; | |||
|
|
|||
| const arbitrum: Chain = { | |||
There was a problem hiding this comment.
any way we can use the Chains package for this?
|
/release-pr |
1 similar comment
|
/release-pr |
No description provided.