Skip to content

Conversation

@nachoiacovino
Copy link
Contributor

No description provided.

@nachoiacovino nachoiacovino requested a review from jnsdls September 2, 2022 01:45
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

🦋 Changeset detected

Latest commit: 61cd8ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anytime u see waitForText think -> const mapping

@jnsdls jnsdls enabled auto-merge (squash) September 2, 2022 18:35
@jnsdls jnsdls disabled auto-merge September 2, 2022 18:38
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsdls jnsdls merged commit e9e71cf into main Sep 2, 2022
@jnsdls jnsdls deleted the ni/cli-tests branch September 2, 2022 20:44
@github-actions github-actions bot mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants