Skip to content

[SDK] Fix single event listener #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnsdls merged 6 commits into from
Aug 29, 2022
Merged

[SDK] Fix single event listener #7

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e21bbd1
fix single event listener
joaquim-verges Aug 29, 2022
8a96533
remove skipped test
joaquim-verges Aug 29, 2022
5a0343a
add changeset
joaquim-verges Aug 29, 2022
930ddf2
change version script
joaquim-verges Aug 29, 2022
48244c4
remove init changeset
joaquim-verges Aug 29, 2022
5ba90cf
fix tests
joaquim-verges Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove skipped test
  • Loading branch information
@joaquim-verges
joaquim-verges committed Aug 29, 2022
commit 8a96533e026b40995182d080b52b0ccc63590db2
23 changes: 0 additions & 23 deletions packages/sdk/test/events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,29 +105,6 @@ describe("Events", async () => {
expect(events.map((e) => e.eventName)).to.include("TokensClaimed");
});

// TODO
it.skip("should emit Signature events", async () => {
const RPC_URL = "https://rpc-mumbai.maticvigil.com/";
const provider = ethers.getDefaultProvider(RPC_URL);
const wallet = Wallet.createRandom().connect(provider);
const esdk = new ThirdwebSDK(wallet, {
gasless: {
openzeppelin: {
relayerUrl: "https://google.com", // TODO test relayer url?
},
},
});
sdk.on(EventType.Transaction, (event) => {
console.log(event);
});
sdk.on(EventType.Signature, (event) => {
console.log(event);
});
await esdk
.getNFTDrop(dropContract.getAddress())
.setApprovalForAll(ethers.constants.AddressZero, true);
});

it("should return single event", async () => {
await nftContract.mintToSelf({
name: "Test1",
Expand Down