-
Notifications
You must be signed in to change notification settings - Fork 630
allow wallet config #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
allow wallet config #808
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
24ebb79
allow wallet config, fix gnosis safe
MananTank d343958
remove console log
MananTank 20a4bf9
Fix icon size issue with reset css
MananTank 89a0743
export wallet classes
MananTank 6d5138a
allow getting email from paper wallet
MananTank 1f203c7
remove unnecessary try-catch
MananTank 45a84be
remove unnecessary comments
MananTank 9fe0630
Merge branch 'main' into allow-wallet-config
MananTank 555d23f
Merge branch 'main' into allow-wallet-config
MananTank 10bd90b
add changeset
MananTank 8271dd3
merge
92d26a9
merge
c76fd4f
Merge branch 'main' into allow-wallet-config
iketw 4653b96
Merge branch 'main' into allow-wallet-config
bd07a54
Merge branch 'allow-wallet-config' of github.com:thirdweb-dev/js into…
646dc4a
react-native fixes
2c05798
Merge branch 'main' into allow-wallet-config
89629b4
descriptive console.error
b245c50
fix bug in wcv2, optionalChains are not optional
b37c673
[RN] coinbase-wallet allow passing callbackURL
74f8928
Remove duplicate prop
MananTank 063cd33
use react-query in usePaperWalletUserEmail()
MananTank 337e678
Merge branch 'main' into allow-wallet-config
MananTank 2f9750e
Update Paper SDK version
MananTank 66bd21c
wallets: fix build error after updating paper sdk version
MananTank 10366f5
auth: export PrivateKeyWallet
MananTank 53d6247
- [RN] add listener for coinbase wallet
2f4e1e5
changeset
44b6282
Merge branch 'main' into allow-wallet-config
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[RN] coinbase-wallet allow passing callbackURL
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this fallback URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iketw
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jnsdls that URL is required by the Coinbase Wallet SDK as a UniversalLink to talk back to iOS apps: https://coinbase.github.io/wallet-mobile-sdk/docs/client-sdk/rn-setup/#configuration.
I'm voting for removing the Coinbase wallet as a default wallet and figure out tree-shaking. Adding UniversalLinks is another friction point to build a new app + breaking Expo Go support. I opened a ticket with them as well: https://github.com/coinbase/wallet-mobile-sdk/issues/213.