-
Notifications
You must be signed in to change notification settings - Fork 589
Version Packages #8102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Version Packages #8102
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoves a changeset entry and bumps versions across packages. Updates changelogs for nebula (0.2.53), thirdweb (5.108.0), and wagmi-adapter (0.2.150). No code or public API changes; all edits are metadata and documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Add a one‑liner to avoid an empty section.Recommend noting “Version bump only; no user‑facing changes” for 0.2.150.
## 0.2.150 + +- Internal: version bump only (no user-facing changes)packages/thirdweb/CHANGELOG.md (1)
3-8
: Polish changelog phrasing + inline code formattingRecommend using backticks for the function name and “IDs” capitalization for consistency with prior entries.
- - [#8091](https://github.com/thirdweb-dev/js/pull/8091) [`5249cb7`](https://github.com/thirdweb-dev/js/commit/5249cb7409a8486346fe428f824c81dd90845555) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Accept arbitrary chain ids for x402 payments with new verifyPayment() backend utility + - [#8091](https://github.com/thirdweb-dev/js/pull/8091) [`5249cb7`](https://github.com/thirdweb-dev/js/commit/5249cb7409a8486346fe428f824c81dd90845555) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Accept arbitrary chain IDs for x402 payments via new `verifyPayment()` backend utilityPlease confirm
verifyPayment()
is exported in [email protected]’s public API and covered in docs, matching the Minor bump rationale.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/some-moons-burn.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/some-moons-burn.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.json
packages/thirdweb/package.json
packages/nebula/package.json
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/nebula/CHANGELOG.md (1)
3-9
: Changelog entry reads well.Notes the dependency update to [email protected] with commit reference. Nothing else needed.
packages/nebula/package.json (1)
60-60
: LGTM — confirm workspace dep resolves to [email protected] on publish.packages/nebula/package.json uses "thirdweb": "workspace:". Confirm a local workspace package named "thirdweb" exists at version 5.108.0 or that Changesets/pnpm will replace "workspace:" with 5.108.0 in the published tarball; repo search failed to locate a local "thirdweb" package (script error).
packages/thirdweb/package.json (1)
430-430
: Approve: semver bump to 5.108.0 — changelog present; add size‑limit config
- Confirmed: packages/thirdweb/CHANGELOG.md contains "## 5.108.0".
- packages/thirdweb/package.json: version bumped; no top‑level "size-limit" config found. devDependency "size-limit" = 11.2.0 and scripts.size = "size-limit". Root package.json also has no top‑level "size-limit".
- Action: add a "size-limit" config at packages/thirdweb or at the repo root to track bundle budgets.
"types": "./dist/types/exports/thirdweb.d.ts", | ||
"typings": "./dist/types/exports/thirdweb.d.ts", | ||
"version": "0.2.149" | ||
"version": "0.2.150" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
LGTM on version bump; double‑check bundle budget tracking.
Version 0.2.150 is fine; peer range thirdweb: ^5.85.0
already covers 5.108.0. Please verify you’re still tracking bundle budgets via package.json#size-limit
for this package (required by guidelines). If missing by design, ignore.
🏁 Script executed:
#!/bin/bash
# Check for size-limit config in updated manifests
rg -n '"size-limit"' packages/wagmi-adapter/package.json packages/nebula/package.json || echo "No size-limit key found in these manifests"
# Sanity: show current thirdweb peer range
jq -r '.peerDependencies.thirdweb' packages/wagmi-adapter/package.json
Length of output: 50
Add missing size-limit entry to packages/wagmi-adapter/package.json
Version bump to 0.2.150 is fine; packages/wagmi-adapter/package.json currently has no "size-limit" entry — add a size-limit budget per repo guidelines or confirm intentional omission.
🤖 Prompt for AI Agents
In packages/wagmi-adapter/package.json around line 58, the version bump to
0.2.150 is present but the file is missing a "size-limit" entry; add a
"size-limit" property to the package.json (matching the repository's size-limit
format and budget used by sibling packages) with the appropriate path(s) and
size budget(s) per repo guidelines, or if omission is intentional add a brief
comment in the PR confirming the deliberate exclusion and referencing the
guideline decision.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8102 +/- ##
=======================================
Coverage 56.32% 56.32%
=======================================
Files 906 906
Lines 59197 59197
Branches 4176 4176
=======================================
Hits 33345 33345
Misses 25746 25746
Partials 106 106
🚀 New features to boost your workflow:
|
0293b67
to
5bd5bf9
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
5249cb7
Thanks @joaquim-verges! - Accept arbitrary chain ids for x402 payments with new verifyPayment() backend utilityPatch Changes
#8100
a94f229
Thanks @MananTank! - Update theonSuccess
,onError
, andonCancel
callback props of theBuyWidget
to be called with thequote
object@thirdweb-dev/[email protected]
Patch Changes
a94f229
,5249cb7
]:@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating the version numbers of various packages and their changelogs, reflecting new releases and changes made in the codebase.
Detailed summary
version
inpackages/thirdweb/package.json
from5.107.1
to5.108.0
version
inpackages/nebula/package.json
from0.2.52
to0.2.53
version
inpackages/wagmi-adapter/package.json
from0.2.149
to0.2.150
0.2.53
inpackages/nebula/CHANGELOG.md
5.108.0
inpackages/thirdweb/CHANGELOG.md
including:verifyPayment()
backend utility for x402 paymentsBuyWidget
componentSummary by CodeRabbit
New Features
Documentation
Chores