Skip to content

If Hide Test Output is Enabled, then don't forward logs to the IOutputDevice #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 11, 2025
Merged

If Hide Test Output is Enabled, then don't forward logs to the IOutputDevice #2360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b086b
If Hide Test Output is Enabled, then don't forward logs to the IOutpu…
thomhurst May 11, 2025
bf1eab1
Fix
thomhurst May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
If Hide Test Output is Enabled, then don't forward logs to the IOutpu… 
…tDevice
  • Loading branch information
@thomhurst
thomhurst committed May 11, 2025
commit 57b086bb61f02ad734ace8e315ceaaa3ea08ba73
10 changes: 7 additions & 3 deletions TUnit.Engine/Logging/TUnitFrameworkLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
using Microsoft.Testing.Platform.Extensions;
using Microsoft.Testing.Platform.CommandLine;
using Microsoft.Testing.Platform.Extensions;
using Microsoft.Testing.Platform.Extensions.OutputDevice;
using Microsoft.Testing.Platform.Logging;
using Microsoft.Testing.Platform.OutputDevice;
using TUnit.Engine.CommandLineProviders;
using LogLevel = TUnit.Core.Logging.LogLevel;

namespace TUnit.Engine.Logging;

internal class TUnitFrameworkLogger(IExtension extension, IOutputDevice outputDevice, ILogger logger)
internal class TUnitFrameworkLogger(IExtension extension, IOutputDevice outputDevice, ILogger logger, ICommandLineOptions commandLineOptions)
: IOutputDeviceDataProducer, global::TUnit.Core.Logging.ILogger
{
private readonly bool _hideTestOutput = commandLineOptions.IsOptionSet(HideTestOutputCommandProvider.HideTestOutput);

private readonly MTPLoggerAdapter _adapter = new(logger);

public Task<bool> IsEnabledAsync()
Expand Down Expand Up @@ -78,6 +82,6 @@ private static ConsoleColor GetConsoleColor(LogLevel logLevel)

public bool IsEnabled(LogLevel logLevel)
{
return logger.IsEnabled(MTPLoggerAdapter.Map(logLevel));
return !_hideTestOutput && logger.IsEnabled(MTPLoggerAdapter.Map(logLevel));
}
}
Loading