-
-
Notifications
You must be signed in to change notification settings - Fork 106
Fix MatrixExclusion inheritance and enum comparison for custom exclusion attributes #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] MatrixExclusion does not exclude
Fix MatrixExclusion inheritance and enum comparison for custom exclusion attributes
Aug 3, 2025
Co-authored-by: thomhurst <[email protected]>
Co-authored-by: thomhurst <[email protected]>
6d306c1 to
06a0d62
Compare
This was referenced Sep 23, 2025
This was referenced Oct 1, 2025
This was referenced Oct 8, 2025
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where custom matrix exclusion attributes that inherit from
MatrixExclusionAttributewere not being recognized, and enum values in exclusions were not being properly compared.Problem
When users create custom exclusion attributes like:
The exclusion was not working - all 5 enum values were being generated instead of the expected 4 (excluding Draft).
Root Cause
Two issues in
MatrixDataSourceAttribute.GetExclusions():OfType<MatrixExclusionAttribute>()which only matches exact types, not derived classesSolution
OfType<MatrixExclusionAttribute>()toWhere(x => x is MatrixExclusionAttribute)to recognize derived attributesIsExcluded()method that converts enum values to their underlying types before comparison, matching the matrix generation behaviorVerification
Before fix:
After fix:
Existing matrix exclusion functionality remains unchanged and working correctly.
Fixes #2663.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.