-
-
Notifications
You must be signed in to change notification settings - Fork 109
IAsyncEnumerable streaming throughout test lifecycle - Discovery > Build > Execute #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
329849d
fix: remove synchronous blocking issues in parallel operations
thomhurst c045748
perf: Major performance optimizations to address 3x test session regr…
thomhurst eaf3960
perf: Implement Stage 1 streaming for test discovery
thomhurst 1a2b863
perf: Implement full end-to-end streaming for test discovery
thomhurst 122c6d2
fix: Resolve compilation errors in streaming implementation
thomhurst e0e2b2d
perf: Add RuntimeHelpers.PrepareMethod optimization for reflection in…
thomhurst 31cc292
feat: Implement true streaming in ReflectionTestDataCollector
thomhurst d90464a
Update snaps
thomhurst efce537
fix: Update GetTestsAsync method signature to include CancellationToken
thomhurst 69d6953
Merge branch 'main' of https://github.com/thomhurst/TUnit
thomhurst d70bce0
Merge branch 'main' into feature/perf-fixes-07082025
thomhurst 93ba067
Update snaps
thomhurst dbf3df3
fix: Address code review feedback from PR #2821
thomhurst de40d6a
Merge branch 'main' into feature/perf-fixes-07082025
thomhurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf: Major performance optimizations to address 3x test session regr…
…ession Implemented comprehensive performance fixes to resolve 130ms → 400ms regression: ## Reflection Caching (Highest Impact) - Added method caching in ReflectionTestDataCollector with ConcurrentDictionary - Implemented attribute lookup caching in ReflectionAttributeExtractor - Eliminates repeated Type.GetMethods() and GetCustomAttribute() calls ## Async/Parallel Improvements - Removed unnecessary Task.Run wrappers around Parallel.ForEach operations - Added ConfigureAwait(false) to prevent potential deadlocks - Fixed synchronous blocking in AotTestDataCollector and ReflectionTestDataCollector ## Lock Contention Optimizations - BufferedTextWriter: Replaced single lock with per-thread buffers + ReaderWriterLockSlim - Timings: Replaced lock-based list with lock-free ConcurrentBag - Reduced serialization bottlenecks in logging and timing systems ## Memory Allocation Reductions - ExecutionPlan: Pre-sized dictionaries based on test count - DataSourceProcessor: Eliminated LINQ ToArray() calls in hot paths - Added ArrayPool usage for large temporary arrays - Replaced numerous LINQ chains with manual loops in TestDependencyResolver and TestRegistry ## Environment Variable Caching - Created centralized EnvironmentVariableCache class - Eliminated 15+ repeated Environment.GetEnvironmentVariable calls - Cached all TUnit-related environment variables on first access Expected performance improvement: 210-340ms reduction in test session time 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi,
items.ToArray()will pre-size automatically, sinceitemsis anICollection<>source