Skip to content

Worker pattern for maximum-parallel-limit #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Aug 14, 2025
Merged

Worker pattern for maximum-parallel-limit #2910

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ced42d
Clean up whitespace and remove unnecessary comments in TestMetadataGe…
thomhurst Aug 14, 2025
084d122
Fix deadlock when using --maximum-parallel-tests flag
thomhurst Aug 14, 2025
abe08ee
Add TestContext initialization in InvokeTypedTest for consistency
thomhurst Aug 14, 2025
c836d1b
Refactor TestContext usage in test invokers to conditionally declare …
thomhurst Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Clean up whitespace and remove unnecessary comments in TestMetadataGe… 
…nerator.cs
  • Loading branch information
@thomhurst
thomhurst committed Aug 14, 2025
commit 2ced42dac11c7fd247787630ac25a09cddc79c89
18 changes: 8 additions & 10 deletions TUnit.Core.SourceGenerator/Generators/TestMetadataGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private static void GenerateInheritedTestSources(SourceProductionContext context

// Find the concrete implementation of this method in the derived class
var concreteMethod = FindConcreteMethodImplementation(classInfo.TypeSymbol, method);

// Calculate inheritance depth for this test
int inheritanceDepth = CalculateInheritanceDepth(classInfo.TypeSymbol, method);

Expand Down Expand Up @@ -159,11 +159,11 @@ private static int CalculateInheritanceDepth(INamedTypeSymbol testClass, IMethod
{
return 0;
}

// Count how many levels up the inheritance chain the method is declared
int depth = 0;
INamedTypeSymbol? currentType = testClass.BaseType;

while (currentType != null)
{
depth++;
Expand All @@ -173,7 +173,7 @@ private static int CalculateInheritanceDepth(INamedTypeSymbol testClass, IMethod
}
currentType = currentType.BaseType;
}

// This shouldn't happen in normal cases, but return the depth anyway
return depth;
}
Expand Down Expand Up @@ -361,7 +361,7 @@ private static void GenerateSpecificGenericInstantiation(

// Generate AOT-friendly invokers that use the specific types
GenerateAotFriendlyInvokers(writer, testMethod, className, typeArguments);

// Add file location metadata
writer.AppendLine($"FilePath = @\"{testMethod.FilePath.Replace("\\", "\\\\")}\",");
writer.AppendLine($"LineNumber = {testMethod.LineNumber},");
Expand Down Expand Up @@ -562,7 +562,7 @@ private static void GenerateMetadata(CodeWriter writer, Compilation compilation,

// Inheritance depth
writer.AppendLine($"InheritanceDepth = {testMethod.InheritanceDepth},");

// File location metadata
writer.AppendLine($"FilePath = @\"{testMethod.FilePath.Replace("\\", "\\\\")}\",");
writer.AppendLine($"LineNumber = {testMethod.LineNumber},");
Expand Down Expand Up @@ -606,7 +606,7 @@ private static void GenerateMetadataForConcreteInstantiation(CodeWriter writer,

// Inheritance depth
writer.AppendLine($"InheritanceDepth = {testMethod.InheritanceDepth},");

// File location metadata
writer.AppendLine($"FilePath = @\"{testMethod.FilePath.Replace("\\", "\\\\")}\",");
writer.AppendLine($"LineNumber = {testMethod.LineNumber},");
Expand Down Expand Up @@ -1550,7 +1550,6 @@ private static void GenerateConcreteTestInvoker(CodeWriter writer, TestMethodMet
var requiredParamCount = parametersFromArgs.Count(p => !p.HasExplicitDefaultValue && !p.IsOptional && !p.IsParams);

// Generate runtime logic to handle variable argument counts
writer.AppendLine("// Invoke with only the arguments that were provided");
writer.AppendLine("switch (args.Length)");
writer.AppendLine("{");
writer.Indent();
Expand Down Expand Up @@ -1643,7 +1642,6 @@ private static void GenerateConcreteTestInvoker(CodeWriter writer, TestMethodMet
var requiredParamCount = parametersFromArgs.Count(p => !p.HasExplicitDefaultValue && !p.IsOptional && !p.IsParams);

// Generate runtime logic to handle variable argument counts
writer.AppendLine("// Invoke with only the arguments that were provided");
writer.AppendLine("switch (args.Length)");
writer.AppendLine("{");
writer.Indent();
Expand Down Expand Up @@ -4250,7 +4248,7 @@ private static void GenerateConcreteTestMetadataForNonGeneric(

// Generate typed invoker
GenerateTypedInvokers(writer, testMethod, className);

// Add file location metadata
writer.AppendLine($"FilePath = @\"{testMethod.FilePath.Replace("\\", "\\\\")}\",");
writer.AppendLine($"LineNumber = {testMethod.LineNumber},");
Expand Down