-
-
Notifications
You must be signed in to change notification settings - Fork 105
Fix IsEqualTo assertion for double.NaN values #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thomhurst <[email protected]>
Co-authored-by: thomhurst <[email protected]>
Co-authored-by: thomhurst <[email protected]>
Copilot
AI
changed the title
[WIP] Fix IsEqualTo to handle double.NaN correctly
Fix IsEqualTo assertion for double.NaN values
Oct 13, 2025
This was referenced Oct 13, 2025
1 task
This was referenced Oct 14, 2025
This was referenced Nov 6, 2025
This was referenced Nov 13, 2025
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
IsEqualToassertion was failing when comparingdouble.NaNvalues, even though both values were NaN. This is a regression compared to v0.67.19.Result:
Interestingly,
float.NaNcomparisons worked correctly, butdouble.NaNdid not.Root Cause
The
DoubleEqualsAssertionclass was using the==operator to compare double values:According to the IEEE 754 floating-point standard,
NaN == NaNalways returnsfalse, causing the assertion to fail incorrectly.Solution
Changed the comparison to use
double.Equals()instead:The
double.Equals()method correctly treats NaN values as equal, which is the expected behavior for equality assertions.Why float.NaN Worked
float.NaNcomparisons worked correctly because there's no specializedFloatEqualsAssertion. Instead,floatvalues use the genericEqualsAssertion<float>which internally usesEqualityComparer<float>.Default.Equals(), which already handles NaN correctly.Tests Added
Added comprehensive tests for special floating-point values:
Double_NaN_EqualsTo_NaN_Success()Double_PositiveInfinity_EqualsTo_PositiveInfinity_Success()Double_NegativeInfinity_EqualsTo_NegativeInfinity_Success()All tests pass successfully.
Fixes #[issue_number]
Original prompt
Fixes #3359
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.