Skip to content

feat(assertions): re-add some lost assertions #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Oct 21, 2025
Merged

feat(assertions): re-add some lost assertions #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22f944d
feat(assertions): re-add some lost assertions
thomhurst Oct 21, 2025
67cbf83
Merge branch 'main' into bug/3462
thomhurst Oct 21, 2025
8a30629
feat(assertions): re-add some lost assertions
thomhurst Oct 21, 2025
7f585c2
feat(assertions): re-add some lost assertions
thomhurst Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class DefaultValuesAssertionExtensions
/// </summary>
public static DefaultValuesAssertion<TValue> HasDefaultValues<TValue>(this IAssertionSource<TValue> source, bool boolValue = true, int intValue = 0, string stringValue = "default", [CallerArgumentExpression(nameof(boolValue))] string? boolValueExpression = null, [CallerArgumentExpression(nameof(intValue))] string? intValueExpression = null, [CallerArgumentExpression(nameof(stringValue))] string? stringValueExpression = null)
{
source.Context.ExpressionBuilder.Append($".HasDefaultValues({boolValueExpression}, {intValueExpression}, {stringValueExpression})");
source.Context.ExpressionBuilder.Append(".HasDefaultValues("
+ string.Join(", ", new[] { boolValueExpression, intValueExpression, stringValueExpression }.Where(e => e != null)) + ")");
return new DefaultValuesAssertion<TValue>(source.Context, boolValue, intValue, stringValue);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ....Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class DefaultValuesAssertionExtensions
/// </summary>
public static DefaultValuesAssertion<TValue> HasDefaultValues<TValue>(this IAssertionSource<TValue> source, bool boolValue = true, int intValue = 0, string stringValue = "default", [CallerArgumentExpression(nameof(boolValue))] string? boolValueExpression = null, [CallerArgumentExpression(nameof(intValue))] string? intValueExpression = null, [CallerArgumentExpression(nameof(stringValue))] string? stringValueExpression = null)
{
source.Context.ExpressionBuilder.Append($".HasDefaultValues({boolValueExpression}, {intValueExpression}, {stringValueExpression})");
source.Context.ExpressionBuilder.Append(".HasDefaultValues("
+ string.Join(", ", new[] { boolValueExpression, intValueExpression, stringValueExpression }.Where(e => e != null)) + ")");
return new DefaultValuesAssertion<TValue>(source.Context, boolValue, intValue, stringValue);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ....Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class DefaultValuesAssertionExtensions
/// </summary>
public static DefaultValuesAssertion<TValue> HasDefaultValues<TValue>(this IAssertionSource<TValue> source, bool boolValue = true, int intValue = 0, string stringValue = "default", [CallerArgumentExpression(nameof(boolValue))] string? boolValueExpression = null, [CallerArgumentExpression(nameof(intValue))] string? intValueExpression = null, [CallerArgumentExpression(nameof(stringValue))] string? stringValueExpression = null)
{
source.Context.ExpressionBuilder.Append($".HasDefaultValues({boolValueExpression}, {intValueExpression}, {stringValueExpression})");
source.Context.ExpressionBuilder.Append(".HasDefaultValues("
+ string.Join(", ", new[] { boolValueExpression, intValueExpression, stringValueExpression }.Where(e => e != null)) + ")");
return new DefaultValuesAssertion<TValue>(source.Context, boolValue, intValue, stringValue);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...tor.Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class DefaultValuesAssertionExtensions
/// </summary>
public static DefaultValuesAssertion<TValue> HasDefaultValues<TValue>(this IAssertionSource<TValue> source, bool boolValue = true, int intValue = 0, string stringValue = "default", [CallerArgumentExpression(nameof(boolValue))] string? boolValueExpression = null, [CallerArgumentExpression(nameof(intValue))] string? intValueExpression = null, [CallerArgumentExpression(nameof(stringValue))] string? stringValueExpression = null)
{
source.Context.ExpressionBuilder.Append($".HasDefaultValues({boolValueExpression}, {intValueExpression}, {stringValueExpression})");
source.Context.ExpressionBuilder.Append(".HasDefaultValues("
+ string.Join(", ", new[] { boolValueExpression, intValueExpression, stringValueExpression }.Where(e => e != null)) + ")");
return new DefaultValuesAssertion<TValue>(source.Context, boolValue, intValue, stringValue);
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...r.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -17,9 +18,10 @@ public static class StringComparisonAssertionExtensions
/// <summary>
/// Extension method for StringComparisonAssertion.
/// </summary>
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = System.StringComparison.4, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = StringComparison.Ordinal, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualToWithComparison({expectedExpression}, {comparisonExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualToWithComparison("
+ string.Join(", ", new[] { expectedExpression, comparisonExpression }.Where(e => e != null)) + ")");
return new StringComparisonAssertion(source.Context, expected, comparison);
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...or.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -17,9 +18,10 @@ public static class StringComparisonAssertionExtensions
/// <summary>
/// Extension method for StringComparisonAssertion.
/// </summary>
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = System.StringComparison.4, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = StringComparison.Ordinal, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualToWithComparison({expectedExpression}, {comparisonExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualToWithComparison("
+ string.Join(", ", new[] { expectedExpression, comparisonExpression }.Where(e => e != null)) + ")");
return new StringComparisonAssertion(source.Context, expected, comparison);
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...or.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -17,9 +18,10 @@ public static class StringComparisonAssertionExtensions
/// <summary>
/// Extension method for StringComparisonAssertion.
/// </summary>
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = System.StringComparison.4, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = StringComparison.Ordinal, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualToWithComparison({expectedExpression}, {comparisonExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualToWithComparison("
+ string.Join(", ", new[] { expectedExpression, comparisonExpression }.Where(e => e != null)) + ")");
return new StringComparisonAssertion(source.Context, expected, comparison);
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...rator.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -17,9 +18,10 @@ public static class StringComparisonAssertionExtensions
/// <summary>
/// Extension method for StringComparisonAssertion.
/// </summary>
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = System.StringComparison.4, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
public static StringComparisonAssertion IsEqualToWithComparison(this IAssertionSource<string> source, string expected, System.StringComparison comparison = StringComparison.Ordinal, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparison))] string? comparisonExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualToWithComparison({expectedExpression}, {comparisonExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualToWithComparison("
+ string.Join(", ", new[] { expectedExpression, comparisonExpression }.Where(e => e != null)) + ")");
return new StringComparisonAssertion(source.Context, expected, comparison);
}
}
Expand Down
4 changes: 3 additions & 1 deletion .../AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -20,7 +21,8 @@ public static class GreaterThanAssertionExtensions
public static GreaterThanAssertion<TValue> IsGreaterThan<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
where TValue : System.IComparable<TValue>
{
source.Context.ExpressionBuilder.Append($".IsGreaterThan({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsGreaterThan("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new GreaterThanAssertion<TValue>(source.Context, expected);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...s/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -20,7 +21,8 @@ public static class GreaterThanAssertionExtensions
public static GreaterThanAssertion<TValue> IsGreaterThan<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
where TValue : System.IComparable<TValue>
{
source.Context.ExpressionBuilder.Append($".IsGreaterThan({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsGreaterThan("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new GreaterThanAssertion<TValue>(source.Context, expected);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...s/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -20,7 +21,8 @@ public static class GreaterThanAssertionExtensions
public static GreaterThanAssertion<TValue> IsGreaterThan<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
where TValue : System.IComparable<TValue>
{
source.Context.ExpressionBuilder.Append($".IsGreaterThan({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsGreaterThan("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new GreaterThanAssertion<TValue>(source.Context, expected);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...ests/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -20,7 +21,8 @@ public static class GreaterThanAssertionExtensions
public static GreaterThanAssertion<TValue> IsGreaterThan<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
where TValue : System.IComparable<TValue>
{
source.Context.ExpressionBuilder.Append($".IsGreaterThan({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsGreaterThan("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new GreaterThanAssertion<TValue>(source.Context, expected);
}
}
Expand Down
7 changes: 5 additions & 2 deletions ...ssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected);
}

Expand All @@ -28,7 +30,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, System.Collections.Generic.IEqualityComparer<TValue> comparer, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparer))] string? comparerExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression}, {comparerExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression, comparerExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected, comparer);
}
}
Expand Down
7 changes: 5 additions & 2 deletions ...AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected);
}

Expand All @@ -28,7 +30,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, System.Collections.Generic.IEqualityComparer<TValue> comparer, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparer))] string? comparerExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression}, {comparerExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression, comparerExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected, comparer);
}
}
Expand Down
7 changes: 5 additions & 2 deletions ...AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Runtime.CompilerServices;
using TUnit.Assertions.Core;
using TUnit.Assertions.Enums;
using TUnit.Assertions.Tests.TestData;

namespace TUnit.Assertions.Extensions;
Expand All @@ -19,7 +20,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected);
}

Expand All @@ -28,7 +30,8 @@ public static class EqualsAssertionExtensions
/// </summary>
public static EqualsAssertion<TValue> IsEqualTo<TValue>(this IAssertionSource<TValue> source, TValue expected, System.Collections.Generic.IEqualityComparer<TValue> comparer, [CallerArgumentExpression(nameof(expected))] string? expectedExpression = null, [CallerArgumentExpression(nameof(comparer))] string? comparerExpression = null)
{
source.Context.ExpressionBuilder.Append($".IsEqualTo({expectedExpression}, {comparerExpression})");
source.Context.ExpressionBuilder.Append(".IsEqualTo("
+ string.Join(", ", new[] { expectedExpression, comparerExpression }.Where(e => e != null)) + ")");
return new EqualsAssertion<TValue>(source.Context, expected, comparer);
}
}
Expand Down
Loading
Loading