-
-
Notifications
You must be signed in to change notification settings - Fork 109
Better exception messages when injected data sources throw #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomhurst
merged 3 commits into
main
from
feature/datasource-failures-exception-propagation2
Dec 19, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| using System.Collections.Concurrent; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Reflection; | ||
| using TUnit.Core.Interfaces; | ||
|
|
||
| namespace TUnit.Core.Discovery; | ||
|
|
||
| /// <summary> | ||
| /// Registry for IAsyncInitializer property metadata generated at compile time. | ||
| /// Used for AOT-compatible nested initializer discovery. | ||
| /// </summary> | ||
| public static class InitializerPropertyRegistry | ||
| { | ||
| private static readonly ConcurrentDictionary<Type, InitializerPropertyInfo[]> Registry = new(); | ||
|
|
||
| /// <summary> | ||
| /// Registers property metadata for a type. Called by generated code. | ||
| /// </summary> | ||
| public static void Register(Type type, InitializerPropertyInfo[] properties) | ||
| { | ||
| Registry[type] = properties; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets property metadata for a type, or null if not registered. | ||
| /// </summary> | ||
| public static InitializerPropertyInfo[]? GetProperties(Type type) | ||
| { | ||
| return Registry.TryGetValue(type, out var properties) ? properties : null; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Checks if a type has registered property metadata. | ||
| /// </summary> | ||
| public static bool HasRegistration(Type type) | ||
| { | ||
| return Registry.ContainsKey(type); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Metadata about a property that returns an IAsyncInitializer. | ||
| /// </summary> | ||
| public sealed class InitializerPropertyInfo | ||
| { | ||
| /// <summary> | ||
| /// The name of the property. | ||
| /// </summary> | ||
| public required string PropertyName { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The property type. | ||
| /// </summary> | ||
| public required Type PropertyType { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// Delegate to get the property value from an instance. | ||
| /// </summary> | ||
| public required Func<object, object?> GetValue { get; init; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message construction spans multiple lines but uses string concatenation which creates multiple temporary strings. Consider using string interpolation for better readability and performance, or using a single multi-line string. For example: $"Failed to access property '{property.Name}' on type '{type.Name}' during object graph discovery. This may indicate that a data source or its nested dependencies failed to initialize. See inner exception for details."