-
-
Notifications
You must be signed in to change notification settings - Fork 109
chore(deps): update dependency microsoft.aspnetcore.mvc.testing to v10 #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to update the Microsoft.AspNetCore.Mvc.Testing dependency from framework-specific versions (8.0.0 for net8.0 and 9.0.0 for net9.0) to version 10.0.1 across both target frameworks. However, this update introduces a critical configuration error where the Version and VersionOverride attributes conflict, and attempts to use a .NET 10.0-specific package version with .NET 8.0 and 9.0 target frameworks.
Key Issues
- Version/VersionOverride Mismatch: The
Versionattribute is set to "10.0.1" whileVersionOverrideremains at the old framework-specific versions ("8.0.0" and "9.0.0"), creating inconsistent behavior depending on whether Central Package Management is enabled - Framework Compatibility: Microsoft.AspNetCore.Mvc.Testing 10.0.1 is designed for .NET 10.0, not for .NET 8.0 or 9.0
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="8.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.0" VersionOverride="9.0.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="9.0.0" /> |
Copilot
AI
Dec 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Version attribute has been updated to 10.0.1, but the VersionOverride attribute still specifies the older framework-specific versions (8.0.0 and 9.0.0). This creates a conflict:
- Line 16: Version="10.0.1" but VersionOverride="8.0.0"
- Line 20: Version="10.0.1" but VersionOverride="9.0.0"
When Central Package Management (CPM) is enabled, VersionOverride takes precedence and will use the older versions (8.0.0 and 9.0.0), ignoring the Version attribute. When CPM is not enabled, it will attempt to use 10.0.1, which may not be compatible with net8.0 and net9.0 target frameworks.
Additionally, Microsoft.AspNetCore.Mvc.Testing version 10.0.1 is designed for .NET 10.0, not .NET 8.0 or 9.0. ASP.NET Core packages are typically framework-specific - version 8.x is for .NET 8.0, version 9.x is for .NET 9.0, and version 10.x is for .NET 10.0.
The correct approach would be to keep the Version attribute matching the VersionOverride for each target framework, ensuring consistent behavior regardless of CPM usage and maintaining proper framework compatibility.
Code Review - PR #4128❌ Issue Identified: Incorrect Package Version ConfigurationThis PR contains a configuration error that will cause confusion and potentially unexpected behavior. ProblemThe changes update the <!-- For net8.0 -->
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="8.0.0" />
<!-- For net9.0 -->
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="9.0.0" />Why This is Wrong
Correct ApproachThe <!-- Option 1: Keep Version matching VersionOverride (clearer) -->
<ItemGroup Condition="'TARGETFRAMEWORK' == 'net8.0'">
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.0" VersionOverride="8.0.0" />
</ItemGroup>
<ItemGroup Condition="'TARGETFRAMEWORK' == 'net9.0'">
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.0" VersionOverride="9.0.0" />
</ItemGroup>
<!-- Option 2: Remove Version attribute entirely -->
<ItemGroup Condition="'TARGETFRAMEWORK' == 'net8.0'">
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="8.0.0" />
</ItemGroup>Root CauseThis appears to be a Renovate bot error. Renovate correctly updated
RecommendationDo not merge this PR as-is. Suggested fix:
Alternatively, configure Renovate to ignore the Additional Notes
Review generated by Claude Code |
This PR contains the following updates:
8.0.0→10.0.19.0.0→10.0.1Release Notes
dotnet/dotnet (Microsoft.AspNetCore.Mvc.Testing)
v9.0.7: .NET 9.0.7You can build .NET 9.0 from the repository by cloning the release tag
v9.0.7and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.6: .NET 9.0.6You can build .NET 9.0 from the repository by cloning the release tag
v9.0.6and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.5: .NET 9.0.5You can build .NET 9.0 from the repository by cloning the release tag
v9.0.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.4: .NET 9.0.4You can build .NET 9.0 from the repository by cloning the release tag
v9.0.4and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.3: .NET 9.0.3You can build .NET 9.0 from the repository by cloning the release tag
v9.0.3and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.2: .NET 9.0.2You can build .NET 9.0 from the repository by cloning the release tag
v9.0.2and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.1: .NET 9.0.1You can build .NET 9.0 from the repository by cloning the release tag
v9.0.1and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.0: .NET 9.0.0You can build .NET 9.0 from the repository by cloning the release tag
v9.0.0and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.18: .NET 8.0.18You can build .NET 8.0 from the repository by cloning the release tag
v8.0.18and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.17: .NET 8.0.17You can build .NET 8.0 from the repository by cloning the release tag
v8.0.17and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.16: .NET 8.0.16You can build .NET 8.0 from the repository by cloning the release tag
v8.0.16and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.15: .NET 8.0.15You can build .NET 8.0 from the repository by cloning the release tag
v8.0.15and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.14: .NET 8.0.14You can build .NET 8.0 from the repository by cloning the release tag
v8.0.14and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.13: .NET 8.0.13You can build .NET 8.0 from the repository by cloning the release tag
v8.0.13and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.12: .NET 8.0.12You can build .NET 8.0 from the repository by cloning the release tag
v8.0.12and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.11: .NET 8.0.11You can build .NET 8.0 from the repository by cloning the release tag
v8.0.11and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.10: .NET 8.0.10You can build .NET 8.0 from the repository by cloning the release tag
v8.0.10and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.8: .NET 8.0.8You can build .NET 8.0 from the repository by cloning the release tag
v8.0.8and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.7: .NET 8.0.7You can build .NET 8.0 from the repository by cloning the release tag
v8.0.7and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.6: .NET 8.0.6You can build .NET 8.0 from the repository by cloning the release tag
v8.0.6and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.5: .NET 8.0.5You can build .NET 8 from the repository by cloning the release tag
v8.0.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.4: .NET 8.0.4You can build .NET 8.0 from the repository by cloning the release tag
v8.0.4and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.3: .NET 8.0.3You can build .NET 8.0 from the repository by cloning the release tag
v8.0.3and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.2: .NET 8.0.2You can build .NET 8.0 from the repository by cloning the release tag
v8.0.2and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.1: .NET 8.0.1You can build .NET 8.0 from the repository by cloning the release tag
v8.0.1and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dotnet.microsoft.com/download/dotnet/release-key-2023.asc
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.