perf: replace fixed length List with Span
#4153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
List<string>withSpan<string?>, modern collection expressions will generate a fixed lengthstruct,nullinitialise it and then cast intoSpan<string?>.This trick could probably be used in other areas, along with
ValueListBuilderandValueStringBuilder.Not sure if it's worth using
Debug.Assertto ensure thatelementscontainsmaxElements + 1values, I don't seeTUnitusing it very much.