Skip to content

perf: remove unnecessary loop #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 10, 2026
Merged

perf: remove unnecessary loop #4215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions TUnit.Core/Tracking/ObjectTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,23 +60,8 @@ private static ISet<object> FlattenTrackedObjects(ConcurrentDictionary<int, Hash
return ImmutableHashSet<object>.Empty;
}

#if NETSTANDARD2_0
// .NET Standard 2.0 doesn't support HashSet capacity constructor
var result = new HashSet<object>(Helpers.ReferenceEqualityComparer.Instance);
#else
// First pass: calculate total capacity to avoid resizing
var totalCapacity = 0;
foreach (var kvp in trackedObjects)
{
lock (kvp.Value)
{
totalCapacity += kvp.Value.Count;
}
}

// Second pass: populate with pre-sized HashSet
var result = new HashSet<object>(totalCapacity, Helpers.ReferenceEqualityComparer.Instance);
#endif
foreach (var kvp in trackedObjects)
{
lock (kvp.Value)
Expand Down
Loading