Skip to content

Fix TUnit0023 false positive for Func<IDisposable> fields #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Jan 6, 2026
+94 −2
Merged

Fix TUnit0023 false positive for Func<IDisposable> fields #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a8a58a
Initial plan
Copilot Jan 6, 2026
679de71
Fix TUnit0023 false positive for Func<IDisposable> fields
Copilot Jan 6, 2026
6233a5b
Fix null-conditional operator consistency in analyzer
Copilot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions TUnit.Analyzers.Tests/DisposableFieldPropertyAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,4 +1197,92 @@ public void Test1()
"""
);
}

// ========================================
// FUNC<IDISPOSABLE> SHOULD NOT BE FLAGGED
// ========================================

[Test]
public async Task Func_Returning_Disposable_No_Issue()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using System;
using System.Net.Http;
using TUnit.Core;

public interface IMyInterface : IDisposable
{
}

public class MyClass : IMyInterface
{
public void Dispose()
{
Console.WriteLine("disposed");
}
}

public class ExampleTest
{
private readonly Func<IMyInterface> _factory = () => new MyClass();

[Test]
public void Test1()
{
using var t = _factory();
}
}
"""
);
}

[Test]
public async Task Func_Returning_HttpClient_No_Issue()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using System;
using System.Net.Http;
using TUnit.Core;

public class DisposableFieldTests
{
private readonly Func<HttpClient> _clientFactory = () => new HttpClient();

[Test]
public void Test1()
{
using var client = _clientFactory();
}
}
"""
);
}

[Test]
public async Task Property_With_Func_Returning_Disposable_No_Issue()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using System;
using System.Net.Http;
using TUnit.Core;

public class DisposableFieldTests
{
private Func<HttpClient> ClientFactory { get; } = () => new HttpClient();

[Test]
public void Test1()
{
using var client = ClientFactory();
}
}
"""
);
}
}
8 changes: 6 additions & 2 deletions TUnit.Analyzers/DisposableFieldPropertyAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ private static void CheckFieldInitializers(SyntaxNodeAnalysisContext context, IN
if (typeInfo.Type?.IsDisposable() is true || typeInfo.Type?.IsAsyncDisposable() is true)
{
var fieldSymbol = context.SemanticModel.GetDeclaredSymbol(variable) as IFieldSymbol;
if (fieldSymbol != null)
// Only flag if the field type itself is disposable (not e.g. Func<IDisposable>)
if (fieldSymbol != null &&
(fieldSymbol.Type?.IsDisposable() is true || fieldSymbol.Type?.IsAsyncDisposable() is true))
{
createdObjects.TryAdd(fieldSymbol, HookLevel.Test);
break; // Only need to add once
Expand Down Expand Up @@ -145,7 +147,9 @@ private static void CheckFieldInitializers(SyntaxNodeAnalysisContext context, IN
if (typeInfo.Type?.IsDisposable() is true || typeInfo.Type?.IsAsyncDisposable() is true)
{
var propertySymbol = context.SemanticModel.GetDeclaredSymbol(propertyDeclaration) as IPropertySymbol;
if (propertySymbol != null)
// Only flag if the property type itself is disposable (not e.g. Func<IDisposable>)
if (propertySymbol != null &&
(propertySymbol.Type?.IsDisposable() is true || propertySymbol.Type?.IsAsyncDisposable() is true))
{
createdObjects.TryAdd(propertySymbol, HookLevel.Test);
break; // Only need to add once
Expand Down
Loading