Skip to content

perf: reduce allocations with Span.Split and VSB #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 10, 2026
Merged

perf: reduce allocations with Span.Split and VSB #4279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions TUnit.Engine/Exceptions/TUnitFailedException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using TUnit.Core.Exceptions;
using TUnit.Core.Helpers;

namespace TUnit.Engine.Exceptions;

Expand All @@ -23,9 +24,21 @@ private static string FilterStackTrace(string? stackTrace)
return string.Empty;
}

var lines = stackTrace!.Split([Environment.NewLine], StringSplitOptions.None);
var vsb = new ValueStringBuilder(stackalloc char[256]);

return string.Join(Environment.NewLine,
lines.TakeWhile(x => !x.Trim().StartsWith("at TUnit")));
var added = false;
foreach(var range in stackTrace.AsSpan().Split(Environment.NewLine))
{
var slice = stackTrace.AsSpan()[range];
if (slice.Trim().StartsWith("at TUnit"))
{
break;
}
vsb.Append(added ? Environment.NewLine : "");
vsb.Append(slice);
added = true;
}

return vsb.ToString();
}
}
Loading