Skip to content

perf: use ConcurrentDictionary in TestRunner #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 13, 2026
+7 −4
Merged

perf: use ConcurrentDictionary in TestRunner #4359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions TUnit.Engine/Scheduling/TestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using Microsoft.Testing.Platform.Extensions.Messages;
using System.Collections.Concurrent;
using TUnit.Core;
using TUnit.Core.Data;
using TUnit.Engine.Interfaces;
using TUnit.Engine.Logging;
using TUnit.Engine.Services.TestExecution;
Expand Down Expand Up @@ -36,13 +35,17 @@ internal TestRunner(
_testStateManager = testStateManager;
}

private readonly ThreadSafeDictionary<string, TaskCompletionSource<bool>> _executingTests = new();
private readonly ConcurrentDictionary<string, TaskCompletionSource<bool>> _executingTests = new();
private Exception? _firstFailFastException;

public ValueTask ExecuteTestAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
{
if (_executingTests.TryGetValue(test.TestId, out var existingTcs))
{
return new ValueTask(existingTcs.Task);
}
var tcs = new TaskCompletionSource<bool>();
var existingTcs = _executingTests.GetOrAdd(test.TestId, _ => tcs);
existingTcs = _executingTests.GetOrAdd(test.TestId, tcs);

if (existingTcs != tcs)
{
Expand Down
Loading