Skip to content

fix: correct expand-all icon SVG in HTML report#5105

Merged
thomhurst merged 1 commit intothomhurst:mainfrom
slang25:fix-report-expand-all-icon
Mar 8, 2026
Merged

fix: correct expand-all icon SVG in HTML report#5105
thomhurst merged 1 commit intothomhurst:mainfrom
slang25:fix-report-expand-all-icon

Conversation

@slang25
Copy link
Copy Markdown
Contributor

@slang25 slang25 commented Mar 8, 2026

Summary

  • Fixed the "Expand all groups" icon SVG in the HTML report where the top-left and top-right corner paths had broken coordinates drawing outside the 0-16 viewBox, resulting in a wonky/asymmetric icon
  • Corrected by properly mirroring the working bottom corner paths vertically

Test plan

  • Generate an HTML report and visually verify the expand-all icon renders symmetrically with all four corner brackets visible

🤖 Generated with Claude Code

The top-left and top-right corners of the expandAll SVG had broken
coordinates that drew outside the 0-16 viewBox, resulting in a wonky
icon. Fixed by properly mirroring the working bottom corners vertically.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@slang25
Copy link
Copy Markdown
Contributor Author

slang25 commented Mar 8, 2026

Before / After

image

The Before icon has the top-left corner bracket oversized/misshapen and the top-right similarly broken — both had SVG path coordinates drawing outside the 0–16 viewBox. The After shows all four corner brackets rendering symmetrically as intended.

@thomhurst thomhurst merged commit 4ce8731 into thomhurst:main Mar 8, 2026
2 checks passed
This was referenced Mar 9, 2026
BenjaminMichaelis pushed a commit to IntelliTect/EssentialCSharp.Web that referenced this pull request Apr 25, 2026
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.18.37 to
1.19.16.

<details>
<summary>Release notes</summary>

_Sourced from [TUnit's
releases](https://github.com/thomhurst/TUnit/releases)._

## 1.19.16

<!-- Release notes generated using configuration in .github/release.yml
at v1.19.16 -->

## What's Changed
### Other Changes
* Truncate exceptions in GitHub summary tables by @​thomhurst in
thomhurst/TUnit#5108
### Dependencies
* chore(deps): update tunit to 1.19.11 by @​thomhurst in
thomhurst/TUnit#5106
* chore(deps): bump dompurify from 3.3.0 to 3.3.2 in /docs by
@​dependabot[bot] in thomhurst/TUnit#5096
* chore(deps): bump svgo from 3.2.0 to 3.3.3 in /docs by
@​dependabot[bot] in thomhurst/TUnit#5086


**Full Changelog**:
thomhurst/TUnit@v1.19.11...v1.19.16

## 1.19.11

<!-- Release notes generated using configuration in .github/release.yml
at v1.19.11 -->

## What's Changed
### Other Changes
* Fix HTML report sort to also reorder groups by @​thomhurst in
thomhurst/TUnit#5103
* fix: correct expand-all icon SVG in HTML report by @​slang25 in
thomhurst/TUnit#5105
* Avoid some redundant list allocations by @​SimonCropp in
thomhurst/TUnit#4963
* avoid some redundant enumerable alloc by @​SimonCropp in
thomhurst/TUnit#4972
* use char instead of string for joins by @​SimonCropp in
thomhurst/TUnit#4989
### Dependencies
* chore(deps): update dependency nunit to 4.5.1 by @​thomhurst in
thomhurst/TUnit#5097
* chore(deps): update tunit to 1.19.0 by @​thomhurst in
thomhurst/TUnit#5099
* chore(deps): update dependency humanizer to 3.0.10 by @​thomhurst in
thomhurst/TUnit#5101
* chore(deps): update dependency nunit.analyzers to 4.12.0 by
@​thomhurst in thomhurst/TUnit#5102


**Full Changelog**:
thomhurst/TUnit@v1.19.0...v1.19.11

## 1.19.0

<!-- Release notes generated using configuration in .github/release.yml
at v1.19.0 -->

## What's Changed
### Other Changes
* fix: improve CreateTestVariant API and fix void/ValueTask return types
by @​thomhurst in thomhurst/TUnit#5095
### Dependencies
* chore(deps): update tunit to 1.18.37 by @​thomhurst in
thomhurst/TUnit#5094


**Full Changelog**:
thomhurst/TUnit@v1.18.37...v1.19.0

Commits viewable in [compare
view](thomhurst/TUnit@v1.18.37...v1.19.16).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=TUnit&package-manager=nuget&previous-version=1.18.37&new-version=1.19.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants