Skip to content

fix: resolve IndexOutOfRangeException with MethodDataSource<T> on class (#5118) #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Mar 11, 2026
Merged

fix: resolve IndexOutOfRangeException with MethodDataSource<T> on class (#5118) #5137

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f20e48
fix: resolve IndexOutOfRangeException when using MethodDataSource<T> …
thomhurst Mar 11, 2026
75e04c7
fix: address PR review feedback for #5118
thomhurst Mar 11, 2026
425cb2e
fix: address second round of PR review feedback
thomhurst Mar 11, 2026
993cb7a
fix: update snapshot for InheritedTestsFromDifferentProjectTests
thomhurst Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: update snapshot for InheritedTestsFromDifferentProjectTests 
The source generator fix for MethodDataSource<T> now correctly resolves
the target type and generates Factory-based code, changing the output
for this existing test.
  • Loading branch information
@thomhurst
thomhurst committed Mar 11, 2026
commit 993cb7a4019bbd34119d969dfb3773d674cd58f2
28 changes: 25 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/InheritedTestsFromDifferentProjectTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// <auto-generated/>
// <auto-generated/>
#pragma warning disable

#nullable enable
Expand Down Expand Up @@ -36,7 +36,18 @@ internal static class TUnit_TestProject_InheritedTestsFromDifferentProjectTests_
}),
dataSources: new global::TUnit.Core.IDataSourceAttribute[]
{
new global::TUnit.Core.MethodDataSourceAttribute<global::TUnit.TestProject.TestData>("Foo"),
new global::TUnit.Core.MethodDataSourceAttribute("Foo")
{
Factory = (dataGeneratorMetadata) =>
{
async global::System.Collections.Generic.IAsyncEnumerable<global::System.Func<global::System.Threading.Tasks.Task<object?[]?>>> Factory()
{
var result = global::TUnit.TestProject.TestData.Foo();
yield return () => global::System.Threading.Tasks.Task.FromResult(global::TUnit.Core.Helpers.DataSourceHelpers.ToObjectArray(result));
}
return Factory();
}
},
},
testSessionId: testSessionId
);
Expand Down Expand Up @@ -253,7 +264,18 @@ internal static class TUnit_TestProject_InheritedTestsFromDifferentProjectTests_
}),
dataSources: new global::TUnit.Core.IDataSourceAttribute[]
{
new global::TUnit.Core.MethodDataSourceAttribute<global::TUnit.TestProject.TestData>("Foo"),
new global::TUnit.Core.MethodDataSourceAttribute("Foo")
{
Factory = (dataGeneratorMetadata) =>
{
async global::System.Collections.Generic.IAsyncEnumerable<global::System.Func<global::System.Threading.Tasks.Task<object?[]?>>> Factory()
{
var result = global::TUnit.TestProject.TestData.Foo();
yield return () => global::System.Threading.Tasks.Task.FromResult(global::TUnit.Core.Helpers.DataSourceHelpers.ToObjectArray(result));
}
return Factory();
}
},
},
testSessionId: testSessionId
);
Expand Down
Loading