Skip to content

fix: resolve CS8920 when mocking interfaces whose members return static-abstract interfaces #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 7 commits into from
Mar 17, 2026
+439 −13
Merged

fix: resolve CS8920 when mocking interfaces whose members return static-abstract interfaces #5154

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8222c04
fix: resolve CS8920 when mocking interfaces whose members return stat…
Mar 13, 2026
bf1055e
Merge branch 'main' into fix/filter-static-abstract-in-mock-members-b…
lucaxchaves Mar 13, 2026
eb032a0
fix: add missing curly braces, remove unused vars, rename credential …
Mar 13, 2026
ba9b69b
fix: use MockMethodCall<object?> for SAI-returning methods to preserv…
Mar 15, 2026
763cefc
Merge branch 'main' into fix/filter-static-abstract-in-mock-members-b…
lucaxchaves Mar 15, 2026
6def2f3
fix: add XML docs for SAI type-safety loss and tighten WaitsFor test …
Mar 17, 2026
748f8db
fix: update SAI transitive return type snapshot with XML docs
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: update SAI transitive return type snapshot with XML docs
  • Loading branch information
Lucas Chaves committed Mar 17, 2026
commit 748f8db07f71950926c0c484a80abd3c3aa8b1ba
6 changes: 6 additions & 0 deletions ...erator.Tests/Snapshots/Interface_With_Static_Abstract_Transitive_Return_Type.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ namespace TUnit.Mocks.Generated
return new IMyService_GetValue_M0_MockCall(global::TUnit.Mocks.Mock.GetEngine(mock), 0, "GetValue", matchers);
}

/// <summary>Configure the mock setup for <c>GetConfigProvider</c>.</summary>
/// <returns>
/// A <see cref="global::TUnit.Mocks.MockMethodCall{T}"/> typed as <c>object?</c> because the return type
/// contains static abstract members and cannot be used as a generic type argument (CS8920).
/// Pass a value that implements the return interface to <c>.Returns()</c> — incorrect types will cause an <see cref="global::System.InvalidCastException"/> at call time.
/// </returns>
public static global::TUnit.Mocks.MockMethodCall<object?> GetConfigProvider(this global::TUnit.Mocks.Mock<global::IMyService> mock)
{
var matchers = global::System.Array.Empty<global::TUnit.Mocks.Arguments.IArgumentMatcher>();
Expand Down
Loading