Skip to content

Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Mar 26, 2026
Merged

Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests #5253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beedbce
Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests
thomhurst Mar 26, 2026
dd67ea5
Add exactly-once invocation guard tests for skip event receivers
thomhurst Mar 26, 2026
4bb5329
Use DependsOn with ProceedOnFailure for skip event receiver test
thomhurst Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use DependsOn with ProceedOnFailure for skip event receiver test 
Replace [NotInParallel] with [DependsOn(ProceedOnFailure = true)] to
guarantee the verification test runs after the skipped test, not just
prevent parallel execution. This avoids potential ordering-dependent
flakes.
  • Loading branch information
@thomhurst
thomhurst committed Mar 26, 2026
commit 4bb5329f3d8e5a2898bceb8d36e014fdb685048e
4 changes: 2 additions & 2 deletions TUnit.TestProject/LastTestEventReceiverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ public ValueTask OnLastTestInAssembly(AssemblyHookContext context, TestContext t

// Test for skipped event receivers using [Skip] attribute.
// After(Test) hooks don't run for statically skipped tests, so we use a
// separate verification test that runs after the skipped test completes.
[NotInParallel(nameof(SkippedEventReceiverTests))]
// DependsOn verification test that runs after the skipped test completes.
public class SkippedEventReceiverTests
{
public static readonly List<string> Events = [];
Expand All @@ -126,6 +125,7 @@ public async Task SkippedTestWithCustomReason()
}

[Test]
[DependsOn(nameof(SkippedTestWithCustomReason), ProceedOnFailure = true)]
public async Task Verify_SkipEventReceiver_Fired_Exactly_Once()
{
// Events were populated by the SkipEventReceiverAttribute on the skipped test.
Expand Down
Loading