Skip to content

Fix MaxExternalSpansPerTest cap bypass when Activity.Parent chain is broken #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Apr 3, 2026
Merged

Fix MaxExternalSpansPerTest cap bypass when Activity.Parent chain is broken #5352

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cada356
Initial plan
Copilot Apr 3, 2026
ccbcecc
Fix MaxExternalSpansPerTest cap bypass when Activity.Parent chain is …
Copilot Apr 3, 2026
947392d
Address review: fix memory leak, add MaxExternalSpansPerTrace constan…
Copilot Apr 3, 2026
59a4217
Also clean up _externalSpanCountsByTest in OnActivityStopped to fix p…
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also clean up _externalSpanCountsByTest in OnActivityStopped to fix p… 
…re-existing leak

Agent-Logs-Url: https://github.com/thomhurst/TUnit/sessions/99eadeb1-f26a-4f94-8341-dc05e1ad3fe9

Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
  • Loading branch information
@thomhurst
Copilot and thomhurst authored Apr 3, 2026
commit 59a4217612d60655d234408d5184dbd6258653c1
4 changes: 3 additions & 1 deletion TUnit.Engine/Reporters/Html/ActivityCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ private void OnActivityStopped(Activity activity)
// All child spans will have already stopped by this point (children stop before parents).
if (isTUnit && activity.GetTagItem("tunit.test.node_uid") is not null)
{
_testCaseSpanIds.TryRemove(activity.SpanId.ToString(), out _);
var spanId = activity.SpanId.ToString();
_testCaseSpanIds.TryRemove(spanId, out _);
_externalSpanCountsByTest.TryRemove(spanId, out _);
_externalSpanCountsByTrace.TryRemove(traceId, out _);
}
}
Expand Down
Loading