Skip to content

perf: avoid closure allocation in BeforeHookTaskCache.GetOrCreateBeforeAssemblyTask (#6040) #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
May 28, 2026
Merged

perf: avoid closure allocation in BeforeHookTaskCache.GetOrCreateBeforeAssemblyTask (#6040) #6073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf: avoid closure allocation in BeforeHookTaskCache.GetOrCreateBefo… 
…reAssemblyTask (#6040)

Add the same lock-free TryGetValue fast path that
GetOrCreateBeforeClassTask uses, so cache hits skip the GetOrAdd
factory delegate that captures taskFactory + cancellationToken.
  • Loading branch information
@thomhurst
thomhurst committed May 28, 2026
commit a52d9e59dda7aed0cace179cc72580752adc11a8
6 changes: 6 additions & 0 deletions TUnit.Engine/Services/BeforeHookTaskCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ public ValueTask GetOrCreateBeforeTestSessionTask(Func<CancellationToken, ValueT

public ValueTask GetOrCreateBeforeAssemblyTask(Assembly assembly, Func<Assembly, CancellationToken, ValueTask> taskFactory, CancellationToken cancellationToken)
{
// Lock-free fast path avoids allocating a closure on the common cache-hit case.
if (_beforeAssemblyTasks.TryGetValue(assembly, out var existingTask))
{
return new ValueTask(existingTask);
}

var task = _beforeAssemblyTasks.GetOrAdd(assembly, a => taskFactory(a, cancellationToken).AsTask());
return new ValueTask(task);
}
Expand Down
Loading