Skip to content

fix: assign TestDetails before TestContext is published to ClassHookContext.Tests #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Jun 7, 2026
Merged

fix: assign TestDetails before TestContext is published to ClassHookContext.Tests #6182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce74860
fix: assign TestDetails before TestContext is published to ClassHookC…
thomhurst Jun 7, 2026
4f69cd4
refactor: drop unused testName parameter from CreateTestContext
thomhurst Jun 7, 2026
70c23d4
chore: remove accidentally committed diff.txt
thomhurst Jun 7, 2026
819c3ef
refactor: make IContextProvider and ContextProvider internal
thomhurst Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: drop unused testName parameter from CreateTestContext 
testName was never used by the TestContext ctor and is redundant with
testDetails.TestName (now passed before publication). Removed from the
interface, implementation, all six call sites, and test stubs.
  • Loading branch information
@thomhurst
thomhurst committed Jun 7, 2026
commit 4f69cd46e85d732e6bdb597173b12e99701c8f37
3 changes: 1 addition & 2 deletions TUnit.Core/ContextProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public ClassHookContext GetOrCreateClassContext(
/// Creates a test context with proper parent hierarchy
/// </summary>
public TestContext CreateTestContext(
string testName,
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)]
Type classType,
TestBuilderContext testBuilderContext,
Expand All @@ -90,7 +89,7 @@ public TestContext CreateTestContext(
{
var classContext = GetOrCreateClassContext(classType);

var testContext = new TestContext(testName, serviceProvider, classContext, testBuilderContext, cancellationToken)
var testContext = new TestContext(testDetails.TestName, serviceProvider, classContext, testBuilderContext, cancellationToken)
{
// Must be assigned before AddTest publishes the context via ClassHookContext.Tests —
// AfterEvery(Class) hooks can iterate Tests while sibling dynamic tests are still being built.
Expand Down
1 change: 0 additions & 1 deletion TUnit.Core/Services/IContextProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ ClassHookContext GetOrCreateClassContext(
/// partially-built context.
/// </summary>
TestContext CreateTestContext(
string testName,
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)]
Type classType,
TestBuilderContext testBuilderContext,
Expand Down
2 changes: 0 additions & 2 deletions TUnit.Engine/Building/TestBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,6 @@ private async ValueTask<TestContext> CreateTestContextAsync(string testId, TestM
};

var context = _contextProvider.CreateTestContext(
metadata.TestName,
metadata.TestClassType,
testBuilderContext,
testDetails,
Expand Down Expand Up @@ -1173,7 +1172,6 @@ private async Task<Attribute[]> InitializeAttributesAsync(Attribute[] attributes
private TestContext CreateFailedTestContext(TestMetadata metadata, TestDetails testDetails)
{
var context = _contextProvider.CreateTestContext(
metadata.TestName,
metadata.TestClassType,
new TestBuilderContext
{
Expand Down
4 changes: 0 additions & 4 deletions TUnit.Engine/Building/TestBuilderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ private async Task<AbstractExecutableTest[]> GenerateDynamicTests(TestMetadata m
var testBuilderContext = CreateTestBuilderContext(metadata);

var context = _contextProvider.CreateTestContext(
metadata.TestName,
metadata.TestClassType,
testBuilderContext,
testDetails,
Expand Down Expand Up @@ -390,7 +389,6 @@ private async IAsyncEnumerable<AbstractExecutableTest> BuildTestsFromSingleMetad
};

var context = _contextProvider.CreateTestContext(
resolvedMetadata.TestName,
resolvedMetadata.TestClassType,
CreateTestBuilderContext(resolvedMetadata),
testDetails,
Expand Down Expand Up @@ -469,7 +467,6 @@ private AbstractExecutableTest CreateFailedTestForDataGenerationError(TestMetada
};

var context = _contextProvider.CreateTestContext(
metadata.TestName,
metadata.TestClassType,
CreateTestBuilderContext(metadata),
testDetails,
Expand Down Expand Up @@ -523,7 +520,6 @@ private AbstractExecutableTest CreateFailedTestForGenericResolutionError(TestMet
};

var context = _contextProvider.CreateTestContext(
metadata.TestName,
metadata.TestClassType,
CreateTestBuilderContext(metadata),
testDetails,
Expand Down
4 changes: 2 additions & 2 deletions TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ namespace
public .GlobalContext GlobalContext { get; }
public .TestDiscoveryContext TestDiscoveryContext { get; }
public .TestSessionContext TestSessionContext { get; }
public .TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly) { }
[.("Trimming", "IL2111", Justification="Type parameter is annotated at the method boundary.")]
public .ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType) { }
Expand Down Expand Up @@ -2903,7 +2903,7 @@ namespace .Services
.BeforeTestDiscoveryContext BeforeTestDiscoveryContext { get; }
.TestDiscoveryContext TestDiscoveryContext { get; }
.TestSessionContext TestSessionContext { get; }
.TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly);
.ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType);
}
Expand Down
4 changes: 2 additions & 2 deletions TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ namespace
public .GlobalContext GlobalContext { get; }
public .TestDiscoveryContext TestDiscoveryContext { get; }
public .TestSessionContext TestSessionContext { get; }
public .TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly) { }
[.("Trimming", "IL2111", Justification="Type parameter is annotated at the method boundary.")]
public .ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType) { }
Expand Down Expand Up @@ -2903,7 +2903,7 @@ namespace .Services
.BeforeTestDiscoveryContext BeforeTestDiscoveryContext { get; }
.TestDiscoveryContext TestDiscoveryContext { get; }
.TestSessionContext TestSessionContext { get; }
.TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly);
.ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType);
}
Expand Down
4 changes: 2 additions & 2 deletions TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ namespace
public .GlobalContext GlobalContext { get; }
public .TestDiscoveryContext TestDiscoveryContext { get; }
public .TestSessionContext TestSessionContext { get; }
public .TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly) { }
[.("Trimming", "IL2111", Justification="Type parameter is annotated at the method boundary.")]
public .ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType) { }
Expand Down Expand Up @@ -2903,7 +2903,7 @@ namespace .Services
.BeforeTestDiscoveryContext BeforeTestDiscoveryContext { get; }
.TestDiscoveryContext TestDiscoveryContext { get; }
.TestSessionContext TestSessionContext { get; }
.TestContext CreateTestContext(string testName, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.TestContext CreateTestContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly);
.ClassHookContext GetOrCreateClassContext([.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..PublicMethods | ..PublicProperties)] classType);
}
Expand Down
4 changes: 2 additions & 2 deletions TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ namespace
public .GlobalContext GlobalContext { get; }
public .TestDiscoveryContext TestDiscoveryContext { get; }
public .TestSessionContext TestSessionContext { get; }
public .TestContext CreateTestContext(string testName, classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .TestContext CreateTestContext( classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken) { }
public .AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly) { }
public .ClassHookContext GetOrCreateClassContext( classType) { }
}
Expand Down Expand Up @@ -2824,7 +2824,7 @@ namespace .Services
.BeforeTestDiscoveryContext BeforeTestDiscoveryContext { get; }
.TestDiscoveryContext TestDiscoveryContext { get; }
.TestSessionContext TestSessionContext { get; }
.TestContext CreateTestContext(string testName, classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.TestContext CreateTestContext( classType, .TestBuilderContext testBuilderContext, .TestDetails testDetails, .CancellationToken cancellationToken);
.AssemblyHookContext GetOrCreateAssemblyContext(.Assembly assembly);
.ClassHookContext GetOrCreateClassContext( classType);
}
Expand Down
1 change: 0 additions & 1 deletion TUnit.UnitTests/ContextProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public async Task CreateTestContext_PublishesContextWithTestDetailsAlreadyAssign
};

var context = provider.CreateTestContext(
nameof(DummyTestClass.SomeTest),
typeof(DummyTestClass),
new TestBuilderContext { TestMetadata = methodMetadata },
testDetails,
Expand Down
1 change: 0 additions & 1 deletion TUnit.UnitTests/SessionActivityLifecycleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ public ClassHookContext GetOrCreateClassContext(
throw new NotSupportedException();

public TestContext CreateTestContext(
string testName,
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors |
DynamicallyAccessedMemberTypes.PublicProperties |
DynamicallyAccessedMemberTypes.PublicMethods)]
Expand Down
Loading
Loading