Skip to content

Improve error for static attribute attempts #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Improve error for static attribute attempts #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f898371
Improve error for static attribute attempts
composerinteralia Apr 24, 2019
8e7e339
Name first arg of DefinitionProxy#method_missing
composerinteralia Apr 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lib/factory_bot/definition_proxy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,17 @@ def transient(&block)
#
# are equivalent.
def method_missing(name, *args, &block) # rubocop:disable Style/MethodMissing
if args.empty?
association_options = args.first

if association_options.nil?
__declare_attribute__(name, block)
elsif args.first.respond_to?(:has_key?) && args.first.has_key?(:factory)
association(name, *args)
elsif __valid_association_options?(association_options)
association(name, association_options)
else
raise NoMethodError.new(
"undefined method '#{name}' in '#{@definition.name}' factory",
)
raise NoMethodError.new(<<~MSG)
undefined method '#{name}' in '#{@definition.name}' factory
Did you mean? '#{name} { #{association_options.inspect} }'
MSG
end
end

Expand Down Expand Up @@ -187,5 +190,9 @@ def __declare_attribute__(name, block)
add_attribute(name, &block)
end
end

def __valid_association_options?(options)
options.respond_to?(:has_key?) && options.has_key?(:factory)
end
end
end
18 changes: 3 additions & 15 deletions spec/factory_bot/definition_proxy_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,23 +72,11 @@
definition = FactoryBot::Definition.new(:broken)
proxy = FactoryBot::DefinitionProxy.new(definition)

invalid_call = -> { proxy.static_attributes_are_gone true }
invalid_call = -> { proxy.static_attributes_are_gone "true" }
expect(invalid_call).to raise_error(
NoMethodError,
"undefined method 'static_attributes_are_gone' in 'broken' factory",
)
end
end

context "when called with a setter method" do
it "raises a NoMethodError" do
definition = FactoryBot::Definition.new(:broken)
proxy = FactoryBot::DefinitionProxy.new(definition)

invalid_call = -> { proxy.setter_method = true }
expect(invalid_call).to raise_error(
NoMethodError,
"undefined method 'setter_method=' in 'broken' factory",
"undefined method 'static_attributes_are_gone' in 'broken' factory\n" \
"Did you mean? 'static_attributes_are_gone { \"true\" }'\n",
)
end
end
Expand Down