Skip to content

Type (almost) all the things #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PeterJCLaw wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Type (almost) all the things #122

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c81f772
Move to a newer Circle CI convenience image
PeterJCLaw Sep 24, 2022
ae37ef6
CIRCLE_JOB is the new CIRCLE_STAGE
PeterJCLaw Sep 24, 2022
3e22e91
Tidy layout in this stub file
PeterJCLaw Sep 24, 2022
8044aea
Annotate these __repr__s
PeterJCLaw Sep 24, 2022
ddd9749
Functions __name__'s are properties, not methods
PeterJCLaw Sep 24, 2022
17aa9c1
Make these ignores more specific
PeterJCLaw Sep 24, 2022
657b091
Make this signature match all the implementations
PeterJCLaw Sep 24, 2022
f62f4f8
Have mypy show and require error codes for clearer ignoring
PeterJCLaw Sep 24, 2022
f3b1427
Annotate almost everything
PeterJCLaw Sep 24, 2022
4401243
Remove unused type: ignores
PeterJCLaw Sep 24, 2022
e16192d
Spell these ignore codes correctly
PeterJCLaw Sep 24, 2022
8acb7c4
Silence this error for now
PeterJCLaw Sep 24, 2022
ecb7026
Drop unused noqa from typing imports
PeterJCLaw Sep 24, 2022
7048fea
Allow type checking imports to violate layering
PeterJCLaw Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CIRCLE_JOB is the new CIRCLE_STAGE
  • Loading branch information
@PeterJCLaw
PeterJCLaw committed Sep 24, 2022
commit ae37ef68955a8bd9e3e0a2ff1249d22528e5329a
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ references:
restore-build-dependency-cache: &restore-build-dependency-cache
restore_cache:
name: Restore build dependency cache
key: deps-venv-1-{{ .Branch }}-{{ .Environment.CIRCLE_STAGE }}-{{ checksum ".circleci/requirements.txt" }}
key: deps-venv-1-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum ".circleci/requirements.txt" }}

install-build-dependencies: &install-build-dependencies
run:
Expand All @@ -35,7 +35,7 @@ references:
save-build-dependency-cache: &save-build-dependency-cache
save_cache:
name: Save build dependency cache
key: deps-venv-1-{{ .Branch }}-{{ .Environment.CIRCLE_STAGE }}-{{ checksum ".circleci/requirements.txt" }}
key: deps-venv-1-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum ".circleci/requirements.txt" }}
paths:
- "venv"

Expand Down Expand Up @@ -70,15 +70,15 @@ references:
done
- restore_cache:
name: Restore .tox cache
key: deps-tox-1-{{ .Branch }}-{{ .Environment.CIRCLE_STAGE }}-{{ checksum ".checksum" }}
key: deps-tox-1-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum ".checksum" }}
- run:
name: Test
command: |
. venv/bin/activate
tox
- save_cache:
name: Save .tox cache
key: deps-tox-1-{{ .Branch }}-{{ .Environment.CIRCLE_STAGE }}-{{ checksum ".checksum" }}
key: deps-tox-1-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum ".checksum" }}
paths:
- ".tox"

Expand Down