xtask: add no_infer_bin_path flag #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
remove the ci flag and set the default behavior to add binaries to the path and CONSTANTS_MANIFEST to environment variables
gabriele-0201
force-pushed
the
gab_no_infer_bin_path
branch
from
c464b7e to
ccda968
Compare
pepyakin
approved these changes
Feb 23, 2024
Contributor
pepyakin
left a comment
pepyakin
left a comment
There was a problem hiding this comment.
This looks good, way better than prior proposals.
However, it still modifies the env vars of the process. This is fine for now, just a bit sketchy. A cleaner approach would be to supply env variables to each shell invocation.
| #[derive(Debug, Args)] | ||
| pub struct Params { | ||
| /// If the test is executed in CI | ||
| /// By default, binary paths are extracted using the `cargo metadata` command under the key `target_directory`. |
Contributor
There was a problem hiding this comment.
Nit: paths to compiled binaries
Contributor
There was a problem hiding this comment.
Nit: no need details about target I suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the ci flag and set the default behavior to add binaries to the path and CONSTANTS_MANIFEST to environment variables