Sage Attention supports minimal modifications when compiling MS Visual Studio on Windows. #323
+205
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multi-architecture builds.
Windows builds and add a build option for GPU-free platforms.
|
Hi, did you successfully run sageattn3 on Windows with Blackwell GPU? Currently a lot of people are seeing errors like Once this is fixed, I think it's straightforward to add Python ABI3 and libtorch stable ABI to sageattn3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made minimal modifications to the Windows compilation of Sage Attention, only modifying setup.py and the setup.py of Sage attn 3, as well as a header file in attn3, which allowed it to compile successfully in a Windows + VS2022 environment.
I tested the compilation successfully on torch 2.6.0-2.9.1 and cuda 12.4-13.0.