Skip to content

Conversation

@maelle
Copy link
Collaborator

@maelle maelle commented Feb 6, 2025

@maelle maelle requested a review from krlmlr February 6, 2025 13:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ec55713 is merged into main:

  • ❗🐌001_tpch_01: 23.4ms -> 24.6ms [+0.84%, +8.97%]
  • ✔️001_tpch_02: 67.6ms -> 66.6ms [-3.82%, +0.77%]
  • ✔️001_tpch_03: 41.7ms -> 42.7ms [-0.09%, +4.99%]
  • ✔️001_tpch_04: 29.3ms -> 29ms [-4.08%, +2.3%]
  • ✔️001_tpch_05: 59.5ms -> 59.4ms [-2.02%, +1.42%]
  • ✔️001_tpch_06: 12.1ms -> 11.9ms [-4.95%, +0.63%]
  • ✔️001_tpch_07: 75.3ms -> 75ms [-2.65%, +1.83%]
  • ✔️001_tpch_08: 101ms -> 101ms [-2.46%, +1.17%]
  • ✔️001_tpch_09: 70ms -> 69.7ms [-1.89%, +1.11%]
  • ✔️001_tpch_10: 49.6ms -> 49.8ms [-1.61%, +2.58%]
  • ✔️001_tpch_11: 41.8ms -> 41.2ms [-4.29%, +1.28%]
  • ✔️001_tpch_12: 21.6ms -> 21.6ms [-2.36%, +1.78%]
  • ✔️001_tpch_13: 18.5ms -> 18.5ms [-3.14%, +3.04%]
  • ✔️001_tpch_14: 16.7ms -> 16.9ms [-1.83%, +3.77%]
  • ✔️001_tpch_15: 38.8ms -> 38.7ms [-1.88%, +1.78%]
  • ✔️001_tpch_16: 37.7ms -> 37.9ms [-1.14%, +2.24%]
  • ✔️001_tpch_17: 32.8ms -> 32.9ms [-1.76%, +2.17%]
  • ✔️001_tpch_18: 29.4ms -> 29.5ms [-1.85%, +2.09%]
  • ✔️001_tpch_19: 40.4ms -> 40.1ms [-2.51%, +0.97%]
  • ✔️001_tpch_20: 52ms -> 52.4ms [-1.37%, +2.81%]
  • ✔️001_tpch_21: 80.9ms -> 80.4ms [-1.99%, +0.81%]
  • ✔️001_tpch_22: 46.6ms -> 46.6ms [-0.9%, +1.11%]
  • ✔️010_tpch_01: 86ms -> 86.2ms [-3.35%, +3.9%]
  • ✔️010_tpch_02: 71.4ms -> 71.3ms [-1.43%, +1.2%]
  • ✔️010_tpch_03: 58.3ms -> 58ms [-2.53%, +1.59%]
  • ✔️010_tpch_04: 42.5ms -> 42.1ms [-3.46%, +1.46%]
  • ✔️010_tpch_05: 90ms -> 89.1ms [-5.01%, +3.04%]
  • ✔️010_tpch_06: 29ms -> 31.2ms [-0.63%, +15.89%]
  • ✔️010_tpch_07: 103ms -> 102ms [-1.93%, +0.76%]
  • ✔️010_tpch_08: 129ms -> 127ms [-3.26%, +1.37%]
  • ✔️010_tpch_09: 118ms -> 116ms [-3.77%, +1.76%]
  • ✔️010_tpch_10: 75.3ms -> 75.2ms [-3.17%, +3.06%]
  • ✔️010_tpch_11: 38.6ms -> 38.7ms [-4.33%, +4.54%]
  • ✔️010_tpch_12: 53ms -> 51.3ms [-9.14%, +2.95%]
  • ✔️010_tpch_13: 51.8ms -> 50.3ms [-7.87%, +2.22%]
  • ✔️010_tpch_14: 34.2ms -> 35.7ms [-4.63%, +13.09%]
  • ✔️010_tpch_15: 53.6ms -> 52.2ms [-8.4%, +3.23%]
  • ✔️010_tpch_16: 40.2ms -> 39.6ms [-5.84%, +2.86%]
  • ✔️010_tpch_17: 54.7ms -> 52.8ms [-7.83%, +0.92%]
  • ✔️010_tpch_18: 53.1ms -> 54ms [-2.35%, +5.8%]
  • ✔️010_tpch_19: 84.6ms -> 84.2ms [-1.84%, +0.84%]
  • ✔️010_tpch_20: 66.5ms -> 66ms [-6.22%, +4.74%]
  • ✔️010_tpch_21: 252ms -> 253ms [-1.95%, +3.07%]
  • ✔️010_tpch_22: 54ms -> 54.6ms [-1.47%, +3.81%]
  • ✔️100_tpch_01: 349ms -> 345ms [-24.54%, +22.16%]
  • ✔️100_tpch_02: 124ms -> 123ms [-4%, +1.52%]
  • ✔️100_tpch_03: 176ms -> 173ms [-8.55%, +4.65%]
  • ✔️100_tpch_04: 150ms -> 149ms [-6.57%, +5.11%]
  • ✔️100_tpch_05: 265ms -> 273ms [-14.54%, +20.22%]
  • ✔️100_tpch_06: 101ms -> 91.4ms [-20.57%, +1.6%]
  • ✔️100_tpch_07: 223ms -> 230ms [-1.91%, +7.72%]
  • ✔️100_tpch_08: 261ms -> 256ms [-17.82%, +14.21%]
  • ✔️100_tpch_09: 322ms -> 343ms [-4.62%, +17.89%]
  • ✔️100_tpch_10: 203ms -> 215ms [-5.22%, +16.68%]
  • 🚀100_tpch_11: 96.1ms -> 82.7ms [-25.88%, -1.93%]
  • ✔️100_tpch_12: 180ms -> 184ms [-8.64%, +13.28%]
  • ✔️100_tpch_13: 321ms -> 328ms [-2.1%, +6.58%]
  • ✔️100_tpch_14: 115ms -> 115ms [-20.2%, +20.68%]
  • ❗🐌100_tpch_15: 192ms -> 212ms [+3.84%, +17.52%]
  • ✔️100_tpch_16: 124ms -> 123ms [-4.27%, +2.82%]
  • ✔️100_tpch_17: 177ms -> 172ms [-14.84%, +9.19%]
  • ✔️100_tpch_18: 184ms -> 192ms [-5.74%, +14.42%]
  • ✔️100_tpch_19: 277ms -> 272ms [-14.49%, +10.48%]
  • ✔️100_tpch_20: 173ms -> 168ms [-8.4%, +2.19%]
  • ✔️100_tpch_21: 1.39s -> 1.39s [-5.52%, +5.06%]
  • ✔️100_tpch_22: 158ms -> 150ms [-13.38%, +4.12%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr
Copy link
Member

krlmlr commented Feb 7, 2025

Please ping when this is available at least in the GitHub version of roxygen2.

@krlmlr krlmlr marked this pull request as draft February 7, 2025 02:27
@krlmlr krlmlr added this to the 1.0.2 milestone Mar 8, 2025
@krlmlr
Copy link
Member

krlmlr commented Mar 27, 2025

We now also have one: https://ror.org/0335t7e62

@maelle
Copy link
Collaborator Author

maelle commented Mar 28, 2025

@krlmlr this is great to read! I'll try and edit a bunch of DESCRIPTION at once next week or so, to add that ROR where cynkra is an author.

@maelle
Copy link
Collaborator Author

maelle commented Mar 31, 2025

@krlmlr but in the case of duckplyr, cynkra is not an author. Should it be added? If so with what role?

@krlmlr krlmlr marked this pull request as ready for review April 16, 2025 03:36
@krlmlr krlmlr merged commit 39b99d2 into main Apr 16, 2025
1 check passed
@krlmlr krlmlr deleted the ror branch April 16, 2025 03:36
@krlmlr
Copy link
Member

krlmlr commented Apr 16, 2025

I'll check what it looks like on pkgdown without the roxygen2 PR.

@krlmlr
Copy link
Member

krlmlr commented Apr 16, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants