Skip to content

Fix legend key sizes #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Fix legend key sizes #6485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b3623
fix stretchy guide bug
teunbrand May 29, 2025
cd56e92
don't override legend key size
teunbrand May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/guide-colorbar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,10 @@ GuideColourbar <- ggproto(
# We set the defaults in `theme` so that the `params$theme` can still
# overrule defaults given here
if (params$direction == "horizontal") {
theme$legend.key.width <- rel(5)
theme$legend.key.width <- (theme$legend.key.width %||% rel(1)) * 5
valid_position <- c("bottom", "top")
} else {
theme$legend.key.height <- rel(5)
theme$legend.key.height <- (theme$legend.key.height %||% rel(1)) * 5
valid_position <- c("right", "left")
}

Expand Down
6 changes: 5 additions & 1 deletion R/guides-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,11 @@

# Get spacing between guides and margins in absolute units
size <- switch(type, width = width_cm, height = height_cm)
spacing <- sum(rep(spacing, length.out = length(units) - 1))
if (length(units) < 2) {
spacing <- unit(0, "cm")

Check warning on line 945 in R/guides-.R

View check run for this annotation

Codecov / codecov/patch

R/guides-.R#L945 

Added line #L945 was not covered by tests
} else {
spacing <- sum(rep(spacing, length.out = length(units) - 1))
}
margin <- switch(type, width = margin[c(2, 4)], height = margin[c(1, 3)])
margin <- sum(size(margin))

Expand Down