Migrate ReflectionTypeCheck #528
Merged
+221
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
May 1, 2023
Comment on lines
23
to
32
| const types: IMessageType<any>[] = [ | ||
| EnumFieldMessage, | ||
| ScalarMapsMessage, | ||
| MessageMapMessage, | ||
| OneofScalarMemberMessage, | ||
| OneofMessageMemberMessage, | ||
| TestAllTypesProto3, | ||
| TestAllTypesProto2, | ||
| ]; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Grr, sorry. Moving too fast. Guess I rely too much on eslint.
timostamm
approved these changes
May 1, 2023
This was referenced May 24, 2024
This was referenced Aug 10, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the reflection type check functionality to the
test-generateddirectory and removes its dependence on fixtures.