Skip to content

Conversation

@smaye81
Copy link
Collaborator

@smaye81 smaye81 commented May 4, 2023

This removes the concept of fixtures from the repo by doing the following:

  • Remove all fixture files from packages/test-fixtures.
  • Rename packages/test-fixtures to packages/proto.
  • Update all references to test-fixtures to use proto.
  • Generate descriptorSet for the helper in packages/plugin in that directory rather than using an external package as a dep.
  • Update docs

Note: as a follow on, we can convert usages of protoc to buf generate or buf build.

@smaye81 smaye81 requested a review from timostamm May 4, 2023 02:57
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 just one nit about formatting in the manual.

Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants