Use relative path to scapy layers directory #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Scapy-ssl_tls/setup.py copies its layers to: C:\Python27\Lib\site-packages\python27\lib\site-packages\scapy\layers when wheel package is installed. get_layer_files_dst() method returns list of tuples (<folder>, [<files>]), where <folder> is an absolute path. According to distutils documentation it should copy these files where we expect, but it does not work because wheel module does not support absolute paths, and they end up being installed relative to site-packages. Solution: Relative (to sys.prefix) path to scapy installation directory is used now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Scapy-ssl_tls/setup.py copies its layers to:
C:\Python27\Lib\site-packages\python27\lib\site-packages\scapy\layers
when wheel package is installed.
get_layer_files_dst() method returns list of tuples (, []), where is an absolute path. According to distutils documentation it should copy these files where we expect, but it does not work because wheel module does not support absolute paths, and they end up being installed relative to site-packages.
Solution:
Relative (to sys.prefix) path to scapy installation directory is used now.