feat!: support process.env.FORCE_TTY
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
AriPerkkio
changed the title
process.env.FORCE_TTYprocess.env.FORCE_TTY
AriPerkkio
force-pushed
the
feat/force_tty
branch
from
8b2b3cb to
42017d5
Compare
sheremet-va
approved these changes
Jan 13, 2025
sheremet-va
requested changes
Jan 13, 2025
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
browser entry point should also be updated
sheremet-va
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isatty()checks whenprocess.env.FORCE_TTYis setIt makes no sense that TTY check is used to resolve whether colors can be printed. In cases where we have multiple processes running and we are concatenating streams from child processes to main process (that's fully functioning TTY), colors should be enabled.