Skip to content

Add class variable USE_UNIQUE_DUPLICATE_SUFFIX #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackton1 merged 2 commits into from
Nov 9, 2019
Merged

Add class variable USE_UNIQUE_DUPLICATE_SUFFIX #14

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd207c4
Add class variable USE_UNIQUE_DUPLICATE_SUFFIX
andresp99999 Nov 8, 2019
6d11bd1
Change comparison to check for any truthy value
andresp99999 Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions model_clone/mixins/clone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class TestModel(CloneMixin, models.Model):
_clonable_one_to_one_fields = []

UNIQUE_DUPLICATE_SUFFIX = 'copy'
USE_UNIQUE_DUPLICATE_SUFFIX = True

@property
@abc.abstractmethod
Expand Down Expand Up @@ -75,8 +76,9 @@ def _create_copy_of_instance(cls, instance):
.filter(**{'{}__startswith'.format(f.attname): value})
.count()
)
if not str(value).isdigit():
value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count)
if cls.USE_UNIQUE_DUPLICATE_SUFFIX is True:
Copy link
Member

@jackton1 jackton1 Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this check use ?

if cls.USE_UNIQUE_DUPLICATE_SUFFIX:
    ...

Copy link
Contributor Author

@andresp99999 andresp99999 Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

if not str(value).isdigit():
value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count)
if isinstance(f, SlugField):
value = slugify(value)
defaults[f.attname] = value
Expand Down