Skip to content

Conversation

@jackton1
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #296 (b27e591) into main (e8dc042) will increase coverage by 2.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   91.45%   94.22%   +2.76%     
==========================================
  Files           6        6              
  Lines         281      277       -4     
==========================================
+ Hits          257      261       +4     
+ Misses         24       16       -8     
Impacted Files Coverage Δ
model_clone/mixins/clone.py 92.12% <ø> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8dc042...b27e591. Read the comment docs.

@jackton1 jackton1 linked an issue Apr 22, 2021 that may be closed by this pull request
@pep8speaks
Copy link

pep8speaks commented Apr 22, 2021

Hello @jackton1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-22 15:23:08 UTC

Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought

@jackton1 jackton1 changed the title Fixed regression calling instance.full_clean. Fixed regression calling instance.full_clean Apr 22, 2021
@jackton1 jackton1 merged commit fa5b16b into main Apr 22, 2021
@jackton1 jackton1 deleted the fix-regression-with-calling-full-clean branch April 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Regression on full_clean

3 participants