Skip to content

Improve test coverage. #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackton1 merged 8 commits into from
Apr 23, 2021
Merged

Improve test coverage. #299

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe5fbd4
Improve test coverage.
jackton1 Apr 23, 2021
69b162e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 23, 2021
0020345
Merge branch 'main' into feature/improve-test-coverage
jackton1 Apr 23, 2021
bce4845
Update test_clone_mixin.py
jackton1 Apr 23, 2021
6015f4e
Update test_clone_mixin.py
jackton1 Apr 23, 2021
dd18445
Update test_clone_mixin.py
jackton1 Apr 23, 2021
9d1dcf9
Fixed test.
jackton1 Apr 23, 2021
8f2e105
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed test.
  • Loading branch information
@jackton1
jackton1 committed Apr 23, 2021
commit 9d1dcf903ebc1b21587dfb0ae472ff0145ea3b09
5 changes: 4 additions & 1 deletion model_clone/mixins/clone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,10 @@ def __duplicate_m2m_fields(self, duplicate, sub_clone):
objs = through.objects.filter(**{field_name: self.pk})
for item in objs:
if hasattr(through, "make_clone"):
item.make_clone(attrs={field_name: duplicate}, sub_clone=True)
try:
item.make_clone(attrs={field_name: duplicate})
except IntegrityError:
item.make_clone(attrs={field_name: duplicate}, sub_clone=True)
else:
item.pk = None
setattr(item, field_name, duplicate)
Expand Down