Skip to content

Conversation

@jackton1
Copy link
Member

CLoses: #330

@pep8speaks
Copy link

pep8speaks commented Jul 17, 2021

Hello @jackton1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-18 01:12:20 UTC

Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering

jackton12 and others added 6 commits July 17, 2021 19:13
…nts' of github.com:tj-django/django-clone into feature/resolve-bug-cloning-models-with-unique-constraints
…nts' of github.com:tj-django/django-clone into feature/resolve-bug-cloning-models-with-unique-constraints
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #423 (20619ef) into main (72b5b15) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #423   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          265       287   +22     
=========================================
+ Hits           265       287   +22     
Impacted Files Coverage Δ
model_clone/mixins/clone.py 100.00% <100.00%> (ø)
model_clone/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b5b15...20619ef. Read the comment docs.

jackton12 and others added 16 commits July 17, 2021 19:39
…nts' of github.com:tj-django/django-clone into feature/resolve-bug-cloning-models-with-unique-constraints
…nts' of github.com:tj-django/django-clone into feature/resolve-bug-cloning-models-with-unique-constraints
…nts' of github.com:tj-django/django-clone into feature/resolve-bug-cloning-models-with-unique-constraints
@jackton1 jackton1 merged commit 45530f6 into main Jul 18, 2021
@jackton1 jackton1 deleted the feature/resolve-bug-cloning-models-with-unique-constraints branch July 18, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UniqueConstraint in Model Meta is not considered

3 participants