Rebase with upstream master

.github/dependabot.yml

@@ -0,0 +1,61 @@
+version: 2
+updates:
+  # GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - "dependencies"
+      - "github-actions"
+
+  # Docker
+  - package-ecosystem: "docker"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - "dependencies"
+      - "docker"
+
+  # Go modules - k8s dependencies
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - "dependencies"
+      - "go"
+      - "k8s"
+    allow:
+      - dependency-name: "k8s.io/*"
+
+  # Go modules - controller-runtime dependencies
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - "dependencies"
+      - "go"
+      - "controller-runtime"
+    allow:
+      - dependency-name: "sigs.k8s.io/controller-runtime/*"
+
+  # Go modules - general dependencies
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - "dependencies"
+      - "go"
+      - "general"
+    ignore:
+      - dependency-name: "k8s.io/*"
+      - dependency-name: "sigs.k8s.io/controller-runtime/*"

.github/workflows/chart-push-release.yml

@@ -9,7 +9,7 @@ on:
       - v*
 jobs:
   package-and-push-helm-chart:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: install helm
         uses: azure/[email protected]

.github/workflows/codeql.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     permissions:
       actions: read
       contents: read

.github/workflows/image-push-master.yml

@@ -11,7 +11,7 @@ on:
 
 jobs:
   build-and-push-image-operator:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3
@@ -50,7 +50,7 @@ jobs:
           file: ./Dockerfile
 
   build-and-push-image-config-daemon:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3
@@ -89,7 +89,7 @@ jobs:
           file: ./Dockerfile.sriov-network-config-daemon
 
   build-and-push-image-webhook:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3

.github/workflows/image-push-release.yml

@@ -10,7 +10,7 @@ on:
       - v*
 jobs:
   build-and-push-image-operator:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3
@@ -50,7 +50,7 @@ jobs:
           file: ./Dockerfile
 
   build-and-push-image-config-daemon:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3
@@ -90,7 +90,7 @@ jobs:
           file: ./Dockerfile.sriov-network-config-daemon
 
   build-and-push-image-webhook:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3

.github/workflows/pr-ci-triggers.yml

@@ -4,7 +4,7 @@ on:
 
 jobs:
   vendors-ci-triggers-list:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/github-script@v5
         env:

.github/workflows/pr-labeler.yml

@@ -4,7 +4,7 @@ on:
 
 jobs:
   triage:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/labeler@v3
         with:

.github/workflows/pr-update.yml

@@ -4,7 +4,7 @@ on: pull_request
 jobs:
   execute:
     name: "remove the lgtm label"
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: jpmcb/[email protected]
         with:

.github/workflows/prow.yml

@@ -5,7 +5,7 @@ on:
 
 jobs:
   execute:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: jpmcb/[email protected]
         with:

.github/workflows/test.yml

@@ -10,13 +10,13 @@ jobs:
 
   build:
     name: build
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
 
-    - name: Set up Go 1.22
+    - name: Set up Go 1.23
       uses: actions/setup-go@v3
       with:
-        go-version: 1.22.x
+        go-version: 1.23.x
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
@@ -29,27 +29,36 @@ jobs:
 
   test:
     name: test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
 
-    - name: Set up Go 1.22
+    - name: Set up Go 1.23
       uses: actions/setup-go@v2
       with:
-        go-version: 1.22.x
+        go-version: 1.23.x
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
-    - name: test pkg
-      run: make test-pkg
+    - name: test pkg on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-pkg
 
-    - name: test cmd
-      run: make test-cmd
+    - name: test pkg on openshift
+      run: CLUSTER_TYPE=openshift make test-pkg
 
-    - name: test api
-      run: make test-api
+    - name: test cmd on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-cmd
 
-    - name: test controllers on opensfhit
+    - name: test cmd on openshift
+      run: CLUSTER_TYPE=openshift make test-cmd
+
+    - name: test cmd on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-api
+
+    - name: test api on openshift
+      run: CLUSTER_TYPE=openshift make test-api
+
+    - name: test controllers on openshift
       run: CLUSTER_TYPE=openshift make test-controllers
 
     - name: test controllers on kubernetes
@@ -60,13 +69,13 @@ jobs:
 
   modules:
     name: check go modules
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
 
-    - name: Set up Go 1.22
+    - name: Set up Go 1.23
       uses: actions/setup-go@v2
       with:
-        go-version: 1.22.x
+        go-version: 1.23.x
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
@@ -76,7 +85,7 @@ jobs:
 
   manifests:
     name: check manifests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
     - name: Check out code
       uses: actions/checkout@v2
@@ -86,45 +95,64 @@ jobs:
 
   golangci:
     name: Golangci-lint
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
-    - name: Set up Go 1.22
+    - name: Set up Go 1.23
       uses: actions/setup-go@v2
       with:
-        go-version: 1.22.x
+        go-version: 1.23.x
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
-    - name: golangci-lint
-      uses: golangci/golangci-lint-action@v3
-      with:
-        # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-        version: v1.55.2
+    - name: run lint checks
+      run: make lint
+
+  shellcheck:
+    name: Shellcheck
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@master
+        with:
+          severity: error
 
   test-coverage:
     name: test-coverage
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
 
-    - name: Set up Go 1.22
+    - name: Set up Go 1.23
       uses: actions/setup-go@v2
       with:
-        go-version: 1.22.x
+        go-version: 1.23.x
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
-    - name: test pkg
-      run: make test-pkg
+    - name: test pkg on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-pkg
 
-    - name: test cmd
-      run: make test-cmd
+    - name: test pkg on openshift
+      run: CLUSTER_TYPE=openshift make test-pkg
 
-    - name: test api
-      run: make test-api
+    - name: test cmd on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-cmd
 
-    - name: test controllers on opensfhit
+    - name: test cmd on openshift
+      run: CLUSTER_TYPE=openshift make test-cmd
+
+    - name: test cmd on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-api
+
+    - name: test api on openshift
+      run: CLUSTER_TYPE=openshift make test-api
+
+    - name: test controllers on openshift
       run: CLUSTER_TYPE=openshift make test-controllers
 
+    - name: test controllers on kubernetes
+      run: CLUSTER_TYPE=kubernetes make test-controllers
+
     - name: merge test coverage
       run: make merge-test-coverage
 
@@ -148,15 +176,15 @@ jobs:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v2
 
-      - name: Set up Go 1.22
+      - name: Set up Go 1.23
         uses: actions/setup-go@v3
         with:
-          go-version: 1.22.x
+          go-version: 1.23.x
 
       - name: run test
         run: make test-e2e-conformance-virtual-k8s-cluster-ci
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: ${{ env.TEST_REPORT_PATH }}
@@ -182,15 +210,15 @@ jobs:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v2
 
-      - name: Set up Go 1.22
+      - name: Set up Go 1.23
         uses: actions/setup-go@v3
         with:
-          go-version: 1.22.x
+          go-version: 1.23.x
 
       - name: run test
         run: make test-e2e-conformance-virtual-ocp-cluster-ci
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: ${{ env.TEST_REPORT_PATH }}

.gitignore

@@ -84,3 +84,5 @@ tags
 .idea/
 # test-environment files
 registry-login.conf
+# go telemetry
+.config/