Skip to content

Add tvOS and watchOS #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Thomasdezeeuw merged 1 commit into from
Feb 25, 2023
Merged

Add tvOS and watchOS #1658

Thomasdezeeuw merged 1 commit into from
Feb 25, 2023

Conversation

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw commented Feb 25, 2023

Follow up to #1655.

@Thomasdezeeuw Thomasdezeeuw force-pushed the tvos_and_watchos branch 2 times, most recently from 584e8f2 to 208e504 Compare February 25, 2023 19:51
@notgull
Copy link

notgull commented Feb 25, 2023

It looks like the cfg statements are getting pretty long. Have you considered using cfg_aliases to reduce the size and scope of these blocks?

@Thomasdezeeuw
Copy link
Collaborator Author

Thomasdezeeuw commented Feb 25, 2023 •
edited
Loading

It looks like the cfg statements are getting pretty long. Have you considered using cfg_aliases to reduce the size and scope of these blocks?

There are getting long, but we're not going to add dependencies for this.

@Thomasdezeeuw Thomasdezeeuw merged commit 9bd0e95 into tokio-rs:master Feb 25, 2023
@Thomasdezeeuw Thomasdezeeuw deleted the tvos_and_watchos branch February 25, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thomasdezeeuw @notgull @Darksonn