chore: Avoid allocation if PollSemaphore is unused #3634
Conversation
Darksonn
added
A-tokio-util
| pub struct PollSemaphore { | ||
| semaphore: Arc<Semaphore>, | ||
| permit_fut: ReusableBoxFuture<Result<OwnedSemaphorePermit, AcquireError>>, | ||
| permit_fut: Option<ReusableBoxFuture<Result<OwnedSemaphorePermit, AcquireError>>>, |
There was a problem hiding this comment.
Another alternative that sometimes works is to initialize the ReusableBoxFuture with a zero-sized future, which also would not allocate. But it probably doesn't help much in this specific case.
There was a problem hiding this comment.
Yup! But that wouldn't let us fast-path .try_acquire anymore without an explicit flag, would it?
There was a problem hiding this comment.
Yeah, I don't think it would help here, but it could be done for PollSender, and maybe also the watch/broadcast wrappers in tokio-stream.
NeoLegends
force-pushed
the
feat/optimize-poll-allocation
branch
from
c99fd36 to
4cd3c57
Compare
|
Thank you for the feedback ❤️ I added another commit adding a fast-path for when a permit is immediately available. |
Co-authored-by: Alice Ryhl <[email protected]>
|
Thank you for the PR. 😃 |
Such a PR would be accepted. The same is also the case for the broadcast and watch wrappers in tokio-stream. |
|
🎉 |
2 participants
Motivation
Cloning
PollSemaphoreallocates, even if it ends up unused (e. g. if.try_acquire_ownedis used as a fast-path). This is due to the underlyingReusableBoxFuturewhich is always initialized and holding a future.Solution
This turns the
ReusableBoxFutureoptional, and only initializes it on the first call to.poll_acquire, when it's actually needed.The size of the semaphore doesn't change, rustc is able to exploit the niche in
NonNullinside ofReusableBoxFuture, but this does introduce an additional branch, so not sure this optimization is worth it in the end.If desired I can file a similar PR for
PollSender.