io: add AsyncWriteExt::write_vectored
#3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Apr 5, 2021
Comment on lines
+14
to
+19
| pub struct WriteVectored<'a, 'b, W: ?Sized> { | ||
| writer: &'a mut W, | ||
| bufs: &'a [IoSlice<'b>], | ||
| // Make this future `!Unpin` for compatibility with async trait methods. | ||
| #[pin] | ||
| _pin: PhantomPinned, |
Member
Author
There was a problem hiding this comment.
tbh I'm not totally sure we need two lifetimes here. The test case in the docs works where both are 'a but not sure if that could break some use cases.
Contributor
There was a problem hiding this comment.
I prefer having both lifetimes.
Darksonn
approved these changes
Apr 5, 2021
Contributor
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
This seems good to me. 👍
Do we want a write_all_vectored too?
Member
Author
Yeah that would be cool. I'll make an issue to add it. |
|
Wow. That was super quick. Thanks a lot! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3676
cc @kaimast