Skip to content

runtime: swallow panics in drop(join_handle) #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2022
Merged

runtime: swallow panics in drop(join_handle) #4430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deeb4a2
runtime: swallow panics in drop(join_handle)
BraulioVM Jan 27, 2022
2a6072a
explain why we swallow the panic
BraulioVM Jan 27, 2022
512152b
improve phrasing of the comment
BraulioVM Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve phrasing of the comment 
Co-authored-by: Alice Ryhl <[email protected]>
  • Loading branch information
@BraulioVM @Darksonn
BraulioVM and Darksonn authored Jan 27, 2022
commit 512152b7efe88f2be40950ba7900bccc34ca1ba1
4 changes: 2 additions & 2 deletions tokio/src/runtime/task/harness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ where
// by a Waker on any arbitrary thread.
//
// Panics are delivered to the user via the `JoinHandle`. Given that
// they are dropping it, we assume they are not interested in it,
// and swallow it.
// they are dropping the `JoinHandle`, we assume they are not
// interested in the panic and swallow it.
let _ = panic::catch_unwind(panic::AssertUnwindSafe(|| {
self.core().stage.drop_future_or_output();
}));
Expand Down